From: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Code cleanup.
Date: Mon, 23 Oct 2006 19:29:44 +0200 [thread overview]
Message-ID: <85hcxvhref.fsf@lola.goethe.zz> (raw)
In-Reply-To: <m33b9fvuwi.fsf@kfs-l.imdomain.dk> (Kim F. Storm's message of "Mon\, 23 Oct 2006 18\:50\:21 +0200")
storm@cua.dk (Kim F. Storm) writes:
> David Kastrup <dak@gnu.org> writes:
>
>> At what stage of development (if at all) should such janitorial
>> changes be usually applied?
>
> Code cleanup is usually welcome -- but this is not the time.
Sure.
>> On a completely different tangent: wouldn't it be much more
>> readable (though likely not completely correct in some perverse
>> manner) if diff-mode actually had its TAB positions in column
>> 9,17,25... instead of the customary 8,16,24...? At least in
>> context and unified diffs, that would _much_ better reflect the
>> relative indentation of the actual change than the current
>> behavior.
>>
>> It does not look like `tab-width' can be made to do that, but maybe
>> one could use a display property in order to move the information
>> of column 0 into the fringe.
>
> Simpler would be to put the "diff decoration" in the left margin and
> put the fringe outside the margins. Then the user wouldn't see any
> difference (except that tabs line up correctly).
Ah, I forgot the display margins.
>> But it would probably be saner if tab-width were extended to allow,
>> say, a cons-cell of initial offset and tab-width.
>
> Or a list (1 9 17 t)
> (where t means to repeat tabs every "difference between last two
> elements).
Or a list (8 . #0) for repeated differences of 8, and (9 8 . #1) for
that of 9. Too bad that this print syntax of
(let ((n (list 9 8))) (setcdr (cdr n) (cdr n)) n)
is not accepted by the Lisp reader.
Circular lists are not really the most natural Lisp constructs...
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2006-10-23 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 11:55 Code cleanup David Kastrup
2006-10-23 16:50 ` Kim F. Storm
2006-10-23 17:29 ` David Kastrup [this message]
2006-10-23 18:03 ` David Kastrup
2006-10-23 19:35 ` Stefan Monnier
2006-10-25 18:03 ` Richard Stallman
2006-10-25 19:01 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85hcxvhref.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).