Re: Getting the click position in a string

[David Kastrup <dak@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

David Kastrup <dak@gnu.org> writes:

> Hi,
>
> I am trying to fix mouse.el so that it can heed follow-link properties
> in display strings.  But it does not appear that the mouse click info
> gives the requisite position information: there is posn-string, and
> there is posn-point, but it does not look like there is
> posn-string-pos or whatever else which would be able to pinpoint the
> actual position within a string that is used as a display property or
> before-string or after-string.
>
> Consequently, one can't fetch the text property at the position of the
> click in such a string.
>
> Am I wrong here?

On another tangent, is this change ok?  For implementing follow-link,
I need to take a look at the follow-link binding in the keymap of a
click, not the binding of the click itself.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2081 bytes --]

*** help.el	25 Mar 2006 20:49:31 +0100	1.308
--- help.el	26 Apr 2006 10:08:16 +0200	
***************
*** 525,541 ****
  	  (princ string)))))
    nil)
  
! (defun string-key-binding (key)
!   "Value is the binding of KEY in a string.
! If KEY is an event on a string, and that string has a `local-map'
! or `keymap' property, return the binding of KEY in the string's keymap."
    (let* ((defn nil)
! 	 (start (when (vectorp key)
! 		  (if (memq (aref key 0)
  			    '(mode-line header-line left-margin right-margin))
! 		      (event-start (aref key 1))
! 		    (and (consp (aref key 0))
! 			 (event-start (aref key 0))))))
  	 (string-info (and (consp start) (nth 4 start))))
      (when string-info
        (let* ((string (car string-info))
--- 525,542 ----
  	  (princ string)))))
    nil)
  
! (defun string-key-binding (event &optional key)
!   "With some string EVENT, return the local binding of KEY.
! If EVENT is an event on a string, and that string has a `local-map'
! or `keymap' property, return the binding of KEY in the string's keymap.
! If KEY is not specified, it is taken from the event."
    (let* ((defn nil)
! 	 (start (when (vectorp event)
! 		  (if (memq (aref event 0)
  			    '(mode-line header-line left-margin right-margin))
! 		      (event-start (aref event 1))
! 		    (and (consp (aref event 0))
! 			 (event-start (aref event 0))))))
  	 (string-info (and (consp start) (nth 4 start))))
      (when string-info
        (let* ((string (car string-info))
***************
*** 544,550 ****
  			     (< pos (length string))
  			     (or (get-text-property pos 'local-map string)
  				 (get-text-property pos 'keymap string)))))
! 	(setq defn (and local-map (lookup-key local-map key)))))
      defn))
  
  (defun help-key-description (key untranslated)
--- 545,551 ----
  			     (< pos (length string))
  			     (or (get-text-property pos 'local-map string)
  				 (get-text-property pos 'keymap string)))))
! 	(setq defn (and local-map (lookup-key local-map (or key event))))))
      defn))
  
  (defun help-key-description (key untranslated)

[-- Attachment #3: Type: text/plain, Size: 340 bytes --]


Incidentally, this function looks faulty: it should search the keymap
_and_ the local-map property (in _that_ order) instead of searching at
most one of the two, even if that search would fail.

Apart from fixing it and adding an optional key argument, is help.el
the right place for it?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel