From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: how to control isearch for invisible text Date: Mon, 14 Aug 2006 09:12:04 +0200 Message-ID: <85d5b3yenv.fsf@lola.goethe.zz> References: <854pwh3y55.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1155539567 3730 80.91.229.2 (14 Aug 2006 07:12:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 Aug 2006 07:12:47 +0000 (UTC) Cc: rms@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 14 09:12:42 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GCWcr-0003GS-4Z for ged-emacs-devel@m.gmane.org; Mon, 14 Aug 2006 09:12:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GCWcq-0002vT-Hu for ged-emacs-devel@m.gmane.org; Mon, 14 Aug 2006 03:12:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GCWcb-0002sP-Ow for emacs-devel@gnu.org; Mon, 14 Aug 2006 03:12:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GCWca-0002qo-Q4 for emacs-devel@gnu.org; Mon, 14 Aug 2006 03:12:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GCWca-0002qH-JA for emacs-devel@gnu.org; Mon, 14 Aug 2006 03:12:24 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GCWiL-0005rz-Np for emacs-devel@gnu.org; Mon, 14 Aug 2006 03:18:21 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1GCWcT-0007hF-8h; Mon, 14 Aug 2006 03:12:17 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 475C01C4D3AD; Mon, 14 Aug 2006 09:12:05 +0200 (CEST) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Sun, 13 Aug 2006 20:36:46 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58368 Archived-At: Stefan Monnier writes: >>> I think `occur' always makes things visible because it copies text >>> and overlays are not copied along, so the invisibility gets lost. I >>> do think query-replace should be improved to open invisible text >>> just like isearch does. > >> I agree that query-replace should show invisible text >> when a match occurs inside it. > > For reveal-mode, we should just provide a "pre-redisplay-hook" run, > as the name indicates, just before doing redisplay. That would > allow reveal-mode to do the "show invisible text" even in > query-replace and this without even changing query-replace's code. That is a bit heavy-handed for my taste, at least for this purpose. Such a hook would have to be global, as redisplay is not a buffer-centric activity, and thus every function with a possible need would have to register and unregister there, and check the state across buffers for every redisplay. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum