From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Recent changes to add-to-list Date: Mon, 30 Oct 2006 23:48:25 +0100 Message-ID: <85d589h13a.fsf@lola.goethe.zz> References: <85ejsrlaww.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1162248604 7414 80.91.229.2 (30 Oct 2006 22:50:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2006 22:50:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 30 23:49:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gefx2-0006XJ-45 for ged-emacs-devel@m.gmane.org; Mon, 30 Oct 2006 23:49:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gefx1-0005Yl-Mn for ged-emacs-devel@m.gmane.org; Mon, 30 Oct 2006 17:49:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gefwn-0005W8-0T for emacs-devel@gnu.org; Mon, 30 Oct 2006 17:49:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gefwl-0005US-RT for emacs-devel@gnu.org; Mon, 30 Oct 2006 17:49:36 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gefwl-0005UA-Ho for emacs-devel@gnu.org; Mon, 30 Oct 2006 17:49:35 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gefwl-0002Qz-Iv for emacs-devel@gnu.org; Mon, 30 Oct 2006 17:49:35 -0500 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1Gefwd-0004MQ-QU; Mon, 30 Oct 2006 17:49:28 -0500 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id F36251C452C6; Mon, 30 Oct 2006 23:48:25 +0100 (CET) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Mon\, 30 Oct 2006 08\:33\:10 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61436 Archived-At: Richard Stallman writes: > Note that this walks through the entire list even if the first > comparison already establishes the presence of a list element. That > is very bad, since that is likely the most common use case. > > That is a real slowdown. Since you've written a fix, > would you please install it? I am installing it, but I would ask people who actually use the third argument to `add-to-list' with a generic function to check this out, as I don't have a test case. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum