From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: asm-mode patch to allow per-file comment character setting from file locals Date: Mon, 12 Jun 2006 15:12:00 +0200 Message-ID: <85bqsyfrhb.fsf@lola.goethe.zz> References: <2E2BAEFF-FEAD-4616-87CD-3B77D2734256@alastairs-place.net> <19321565-3F93-4299-996F-8A2081C462AF@alastairs-place.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1150117979 29460 80.91.229.2 (12 Jun 2006 13:12:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jun 2006 13:12:59 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 12 15:12:57 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FpmDr-00010a-6w for ged-emacs-devel@m.gmane.org; Mon, 12 Jun 2006 15:12:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FpmDq-0007e8-IL for ged-emacs-devel@m.gmane.org; Mon, 12 Jun 2006 09:12:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FpmDd-0007dW-9B for emacs-devel@gnu.org; Mon, 12 Jun 2006 09:12:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FpmDc-0007cz-Fq for emacs-devel@gnu.org; Mon, 12 Jun 2006 09:12:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FpmDc-0007cw-Az for emacs-devel@gnu.org; Mon, 12 Jun 2006 09:12:36 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FpmML-0006AS-Hc for emacs-devel@gnu.org; Mon, 12 Jun 2006 09:21:37 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1FpmDb-0002j6-8A; Mon, 12 Jun 2006 09:12:35 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id CEDF41C464FD; Mon, 12 Jun 2006 15:12:00 +0200 (CEST) Original-To: Alastair Houghton In-Reply-To: <19321565-3F93-4299-996F-8A2081C462AF@alastairs-place.net> (Alastair Houghton's message of "Mon, 12 Jun 2006 10:46:06 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55845 Archived-At: Alastair Houghton writes: > On 11 Jun 2006, at 22:20, Stefan Monnier wrote: > >> I don't have time to look in detail at the patch, but here are some >> comments: >> >>> +(make-variable-buffer-local 'asm-comment-char) >> >> Please don't do that. USe make-local-variable where necessary >> instead. > > The reason I chose to use make-variable-buffer-local is that I want > to be able to set it from a file local variables block (either the - > *- version at the top, or the version at the bottom of my assembler > files). Files set from a file local variables block are made buffer-local, anyway. Perhaps reading the documentation will help. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum