From: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Code cleanup.
Date: Wed, 25 Oct 2006 21:01:34 +0200 [thread overview]
Message-ID: <85bqo0xlrl.fsf@lola.goethe.zz> (raw)
In-Reply-To: <E1Gcn66-0006eJ-SB@fencepost.gnu.org> (Richard Stallman's message of "Wed\, 25 Oct 2006 14\:03\:26 -0400")
Richard Stallman <rms@gnu.org> writes:
> The right time for code cleanup would be whenever we
> are installing new features.
>
> However, in my opinion, your change does not either increase
> or decrease readability. It's a tossup.
Uh, setting tem to "", an artificial empty string, in order to have j
incremented once again before breaking out of the finished loop is
readable?
Is this kind of "readable" synonymous to "comprehensible with serious
effort", reminiscent of mathematicians' use of "trivial" as synonymous
with "provable with serious effort"?
If one hits a terminating condition of a loop, one should exit the
loop instead of setting up artificial values to variables that have
the only purpose of causing an exit at a convenient point later in
time.
In other words: while "readability" is certainly a matter of personal
taste, you find me surprised at your taste.
I don't claim that my proposal was perfect, but I would not have
thought it a tossup.
I'll keep my version in my private tree, and will likely sneak it in
after the release. At least I hope that nobody will find my proposal
actually strictly less readable than the original, and so we'll at
least get one developer (myself) marginally more happy without
offending others.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
prev parent reply other threads:[~2006-10-25 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 11:55 Code cleanup David Kastrup
2006-10-23 16:50 ` Kim F. Storm
2006-10-23 17:29 ` David Kastrup
2006-10-23 18:03 ` David Kastrup
2006-10-23 19:35 ` Stefan Monnier
2006-10-25 18:03 ` Richard Stallman
2006-10-25 19:01 ` David Kastrup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85bqo0xlrl.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).