From: David Kastrup <dak@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: "Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>,
rms@gnu.org, emacs-devel@gnu.org
Subject: Re: The *Warnings* buffer and undo
Date: Wed, 28 Mar 2007 21:36:52 +0200 [thread overview]
Message-ID: <85abxxw46j.fsf@lola.goethe.zz> (raw)
In-Reply-To: <ndfy7qmbxj.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue\, 27 Mar 2007 20\:47\:20 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Richard Stallman wrote:
>
>> Does the *Warnings* buffer really need to save undo info? Why not set
>> buffer-undo-list to t in this buffer?
>>
>> I agree completely. Would someone please do that?
>
> Do you mean this:
>
>
> *** warnings.el 21 Jan 2007 02:44:23 -0000 1.11
> --- warnings.el 28 Mar 2007 00:47:05 -0000
> ***************
> *** 237,242 ****
> --- 237,243 ----
> (level-info (assq level warning-levels))
> start end)
> (with-current-buffer buffer
> + (let ((buffer-undo-list t))
I don't think it is a good idea to let-bind buffer-undo-list here:
instead it should generally be set to t in the buffer.
Otherwise undo information will be recorded sparsely (for example, for
user input), leading to inconsistent results.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-03-28 19:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 20:01 The *Warnings* buffer and undo Lennart Borgman (gmail)
2007-03-25 17:27 ` Richard Stallman
2007-03-28 0:47 ` Glenn Morris
2007-03-28 19:36 ` David Kastrup [this message]
2007-03-28 20:52 ` Glenn Morris
2007-03-29 17:59 ` Richard Stallman
2007-03-29 18:35 ` David Kastrup
2007-03-30 12:42 ` Richard Stallman
2007-03-30 19:18 ` Glenn Morris
2007-03-30 19:53 ` Lennart Borgman (gmail)
2007-03-31 7:20 ` Richard Stallman
2007-03-31 19:41 ` Glenn Morris
2007-03-31 23:21 ` Richard Stallman
2007-03-29 22:07 ` Miles Bader
2007-03-30 21:23 ` Richard Stallman
2007-03-30 21:45 ` Glenn Morris
2007-03-30 22:50 ` Miles Bader
2007-03-31 20:43 ` Richard Stallman
2007-04-01 0:22 ` Miles Bader
2007-04-01 0:44 ` Miles Bader
2007-03-29 15:32 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85abxxw46j.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lennart.borgman@gmail.com \
--cc=rgm@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).