From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Additional cleanup around xterm-mouse Date: Sun, 20 Dec 2020 15:27:10 -0800 Message-ID: <858d85fc265455042479cb4c9a72b4a5@finder.org> References: <83o8jupnqd.fsf@gnu.org> <838savys2v.fsf@gnu.org> <3e3933d8ec1d5d3f6809385a8ac5f447@finder.org> <83mtz1moa5.fsf@gnu.org> <0ea60a4f2a7fb0698f84ac5957cafef3@finder.org> <83mtyxgzck.fsf@gnu.org> <2eac7957a7c20af3517a3ad0862a5b39@finder.org> <106c6d31ef09b83042ef0fab5ac0ed88@finder.org> <505d1b561cde375d1c6a55a738cd553d@finder.org> <83ft48csj5.fsf@gnu.org> <83bleptzng.fsf@gnu.org> <831dc4a610325c009c5a10c48fe459e5@finder.org> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.3.15 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 21 00:27:54 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kr87G-000AGr-4v for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Dec 2020 00:27:54 +0100 Original-Received: from localhost ([::1]:33842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr87F-0003JX-6O for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Dec 2020 18:27:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr86c-0002u6-NC for emacs-devel@gnu.org; Sun, 20 Dec 2020 18:27:14 -0500 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:45320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr86a-0004zo-VK; Sun, 20 Dec 2020 18:27:14 -0500 Original-Received: from mail.finder.org (greenhill.hpalace.com [IPv6:2600:3c01::f03c:91ff:fe73:2daa]) by greenhill.hpalace.com (Postfix) with ESMTPSA id AED06845; Sun, 20 Dec 2020 23:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=finder.org; s=2018; t=1608506830; bh=XtiAeEZ8WOY+e0AqQc3QoSCKlCwz8MF0zxjFjbsb7I0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g39FpoXvUzGhKiUUKBnc2TPIn/BIT6f94kaGBWjdJc1nd7lWlk6KU/6vU1oPD9Mjw UIoic0CrrNqbjPp5F4cTa72YB5XrgPm5PxZMK9/E1AIVL7AqpS/CY+Gf2aPS25qVpG WLK6K25bn43l98Z0WAiiLQb0S0arJPRZjORcZ1eHaMdRNUHnZeNmwv7PGW9gpLprl2 RWbpxP/FG0i6dpuvN2aLUnOx5YS0SBxq0tnN2B/0q+oazM/d0gw3BzUdS/pOnc9vTA pLdnPtmZYqa+QG5seqmmX2oQphsNa+ykdQtFo/tKsWMMuV26EVl9X2fp+95Hy0Kda/ MJtXeYNc/dQ7Q== In-Reply-To: X-Sender: jared@finder.org Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261360 Archived-At: On 2020-12-20 6:07 am, Stefan Monnier wrote: >> I see a few options: >> >> 1. Change the behavior of the dont-downcase-last parameter to this >> more >> extensive meaning. Update global-set-key (the only other caller >> who sets >> dont-downcase-last in Emacs' code) to take this new behavior >> into account. > > I believe `global-set-key` does want to use this new behavior, yes. > >> 2. Make the dont-downcase-last parameter have the new behavior only if >> it is >> passed some new value (for example: 'all-fallbacks). Leave the >> existing >> behavior for any other value, especially 'nil and 't. >> >> 3. [My preference] Like 2, but with a deprecation message on values >> other >> than 'nil, 'all-fallbacks, or 't (or maybe 'downcase-last if we >> want full >> explicitness). This allows maximal ability to define new behaviors >> in >> the future. > > These sound good as well. I'd even put a deprecation message on the > `downcase-last` case. > >> I like #3 as existing code would run unchanged. The chance that any >> existing code passed 'all-fallbacks is extremely low. And anyone >> supporting >> a package outside of Emacs passing some other value will notice the >> message >> when they upgrade to Emacs 28. >> >> Thoughts? > > By order of preference, I'd say: #1, then #3 and finally #2. > But any one of those 3 is OK for me. Sounds good to me! Eli, do you have a preference here? I'd like to make sure I implement the right option. -- MJF