From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Jim Meyering <jim@meyering.net>
Newsgroups: gmane.comp.gnu.core-utils.bugs,gmane.emacs.devel
Subject: Re: dired doesn't work properly with a multibyte locale
Date: Mon, 27 Jan 2003 14:35:55 +0100
Sender: bug-coreutils-bounces+gcgcb-bug-coreutils-616=gmane.org@gnu.org
Message-ID: <857kcqk950.fsf@pi.meyering.net>
References: <buok7hibyqd.fsf@mcspd15.ucom.lsi.nec.co.jp>
	<200301151043.TAA09856@etlken.m17n.org>
	<buovg0gpjvb.fsf@mcspd15.ucom.lsi.nec.co.jp>
	<200301230602.PAA07755@etlken.m17n.org>
	<buoel74pf7k.fsf@mcspd15.ucom.lsi.nec.co.jp>
	<200301250049.JAA11674@etlken.m17n.org>
	<buoptqjb51e.fsf@mcspd15.ucom.lsi.nec.co.jp>
	<jey956n9n3.fsf@sykes.suse.de>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1043681495 2974 80.91.224.249 (27 Jan 2003 15:31:35 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 27 Jan 2003 15:31:35 +0000 (UTC)
Cc: Miles Bader <miles@gnu.org>
Return-path: <bug-coreutils-bounces+gcgcb-bug-coreutils-616=gmane.org@gnu.org>
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 18dBET-0000lo-00
	for <gcgcb-bug-coreutils-616@gmane.org>; Mon, 27 Jan 2003 16:31:33 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18dB4G-0005Jd-02
	for gcgcb-bug-coreutils-616@gmane.org; Mon, 27 Jan 2003 10:21:00 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13)
	id 18d9SU-0004yn-00
	for bug-coreutils@gnu.org; Mon, 27 Jan 2003 08:37:54 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13)
	id 18d9Re-0004me-00
	for bug-coreutils@gnu.org; Mon, 27 Jan 2003 08:37:18 -0500
Original-Received: from anice-201-1-1-11.abo.wanadoo.fr ([80.13.35.11])
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18d9RJ-0004j8-00; Mon, 27 Jan 2003 08:36:41 -0500
Original-Received: by ANice-201-1-1-11.abo.wanadoo.fr (Postfix, from userid 1002)
	id 06DD43FD3; Mon, 27 Jan 2003 14:35:55 +0100 (CET)
Original-To: Andreas Schwab <schwab@suse.de>
In-Reply-To: <jey956n9n3.fsf@sykes.suse.de> (Andreas Schwab's message of "Mon,
	27 Jan 2003 11:56:48 +0100")
Original-Lines: 18
Original-cc: bug-coreutils@gnu.org
Original-cc: emacs-pretest-bug@gnu.org
Original-cc: Kenichi Handa <handa@m17n.org>
Original-cc: emacs-devel@gnu.org
X-BeenThere: bug-coreutils@gnu.org
X-Mailman-Version: 2.1b5
Precedence: list
List-Id: GNU Core Utilities: bug reports and discussion
	<bug-coreutils.gnu.org>
List-Help: <mailto:bug-coreutils-request@gnu.org?subject=help>
List-Post: <mailto:bug-coreutils@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/bug-coreutils>,
	<mailto:bug-coreutils-request@gnu.org?subject=subscribe>
List-Archive: <http://mail.gnu.org/pipermail/bug-coreutils>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/bug-coreutils>,
	<mailto:bug-coreutils-request@gnu.org?subject=unsubscribe>
Errors-To: bug-coreutils-bounces+gcgcb-bug-coreutils-616=gmane.org@gnu.org
Xref: main.gmane.org gmane.comp.gnu.core-utils.bugs:92 gmane.emacs.devel:11130
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11130

> Here is a patch.  The dired offset are documented as being byte counts,
> not character counts.  The bug happens in any multibyte locale.
>
> Andreas.
>
> 2003-01-27  Andreas Schwab  <schwab@suse.de>
>
> 	* src/ls.c (quote_name): Add fourth parameter width into which to
> 	store the screen columns and return number of bytes instead.
> 	(print_dir): Pass NULL as fourth parameter of quote_name.
> 	(print_name_with_quoting): Likewise.
> 	(length_of_file_name_and_frills): Get the width from the fourth
> 	parameter of quote_name instead of return value.

Hi Andreas!

Thanks for that patch.
I've applied it.