From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Zhiwei Chen Newsgroups: gmane.emacs.devel Subject: Re: Highlight current line when using gud Date: Thu, 1 Jul 2021 03:17:22 +0000 Message-ID: <851BB31A-011B-47A5-9B3C-8878543C1533@kuaishou.com> References: <46933061-DFBC-406C-8489-F3DC7EE770BA@kuaishou.com> <87sg0z8t5t.fsf@gnus.org> <6F39630A-1FF8-45DE-9E3B-D9E8BE906BD7@kuaishou.com> <83o8bnmqyo.fsf@gnu.org> <62662FDA-8D67-459B-8F03-662010FB96EB@kuaishou.com> <83bl7nmjvr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_004_851BB31A011B47A59B3C8878543C1533kuaishoucom_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11136"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , "condy0919@gmail.com" , "emacs-devel@gnu.org" To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 01 05:18:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lynDT-0002jU-5H for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jul 2021 05:18:15 +0200 Original-Received: from localhost ([::1]:56632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lynDR-0006qy-ED for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Jun 2021 23:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lynCq-00060f-Qa for emacs-devel@gnu.org; Wed, 30 Jun 2021 23:17:36 -0400 Original-Received: from smtpcn03.kuaishou.com ([103.107.217.217]:1637 helo=bjm7-spam01.kuaishou.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lynCn-0005Nw-Kb; Wed, 30 Jun 2021 23:17:36 -0400 Original-Received: from bjfk-pm-mail14.kuaishou.com ([172.29.5.42]) by bjm7-spam01.kuaishou.com with ESMTP id 1613HMLA098402; Thu, 1 Jul 2021 11:17:22 +0800 (GMT-8) (envelope-from chenzhiwei03@kuaishou.com) Content-Language: zh-CN DKIM-Signature: v=1; a=rsa-sha256; d=kuaishou.com; s=dkim; c=relaxed/relaxed; t=1625109442; h=from:subject:to:date:message-id; bh=jF3yP4GEw/z4Gw4/40AzcthtegfqgtbZDhdfAGIkpEg=; b=BOSQvYQ70YcKiRlOQx11eMW0+gijq2ltXe8ycANkYX7urkexNuD0nrcyZIc2TgtDFnVJ/66Nsan AF9uuDNyJKZU15J32KQ4zrZ6GiMzeXzhQ8IFjDTJnlascjT0d7QW3abAlZWTr31NYWbGFVsNfR2dF IKXthaf0Hu8qdRivXD4= Original-Received: from bjfk-pm-mail15.kuaishou.com (172.29.5.43) by bjfk-pm-mail14.kuaishou.com (172.29.5.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 1 Jul 2021 11:17:22 +0800 Original-Received: from bjfk-pm-mail15.kuaishou.com ([fe80::7dae:bfab:2aec:940b]) by bjfk-pm-mail15.kuaishou.com ([fe80::7dae:bfab:2aec:940b%19]) with mapi id 15.01.2176.009; Thu, 1 Jul 2021 11:17:22 +0800 Thread-Topic: Highlight current line when using gud Thread-Index: AQHXbiebw4l/t1cDu0GKdpoYQOzpAw== In-Reply-To: <83bl7nmjvr.fsf@gnu.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: yes x-originating-ip: [172.31.70.41] X-MAIL: bjm7-spam01.kuaishou.com 1613HMLA098402 Received-SPF: pass client-ip=103.107.217.217; envelope-from=chenzhiwei03@kuaishou.com; helo=bjm7-spam01.kuaishou.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271091 Archived-At: --_004_851BB31A011B47A59B3C8878543C1533kuaishoucom_ Content-Type: multipart/alternative; boundary="_000_851BB31A011B47A59B3C8878543C1533kuaishoucom_" --_000_851BB31A011B47A59B3C8878543C1533kuaishoucom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > On Jun 30, 2021, at 11:50 PM, Eli Zaretskii wrote: > > Thanks. It all looks to me as differences in personal preferences. I > have no doubt that some of us (myself included) have no problems > finding the current line in the source buffer, and others use > hl-line-mode with the above code and have no problems at all. So I > wonder what would be the best way of adding the feature you want > without disappointing those who like the existing behavior. > FWIW, I'm not opposed to such a change, but it must be an optional feature (we could discuss the default value). I don't think we can force people to use this overlay. Especially since on GUI displays the arrow is shown in the fringe (not to mention the fact that gud-gdb is deprecated in favor of gdb-mi.el). A user option is introduced. -- Zhiwei Chen --_000_851BB31A011B47A59B3C8878543C1533kuaishoucom_ Content-Type: text/html; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable

> On Jun 30, 2021, at 11:50 PM, Eli Zaretskii <eliz@gnu.org> wrote= :
>
> Thanks.  It all looks to me as differences in personal preference= s.  I
> have no doubt that some of us (myself included) have no problems
> finding the current line in the source buffer, and others use
> hl-line-mode with the above code and have no problems at all.  So= I
> wonder what would be the best way of adding the feature you want
> without disappointing those who like the existing behavior.

> FWIW, I'm not opposed to such a change, but it must be an optional
feature (we could discuss the default value).  I don't think we can force people to use this overlay.  Especially since on GUI displays the arrow is shown in the fringe (not to mention the fact that
gud-gdb is deprecated in favor of gdb-mi.el).

A user option is introduced.



--
Zhiwei Chen
--_000_851BB31A011B47A59B3C8878543C1533kuaishoucom_-- --_004_851BB31A011B47A59B3C8878543C1533kuaishoucom_ Content-Type: application/octet-stream; name="0001-lisp-progmodes-gud.el-Highlight-current-line.patch" Content-Description: 0001-lisp-progmodes-gud.el-Highlight-current-line.patch Content-Disposition: attachment; filename="0001-lisp-progmodes-gud.el-Highlight-current-line.patch"; size=2286; creation-date="Thu, 01 Jul 2021 03:17:22 GMT"; modification-date="Thu, 01 Jul 2021 03:17:22 GMT" Content-ID: Content-Transfer-Encoding: base64 RnJvbSA2NTRmM2MyNzI4NzQxMTE3NjQyYzhiNzYyZmI2YTlmYTc4ZmY3MzA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBjb25keSA8Y29uZHkwOTE5QGdtYWlsLmNvbT4KRGF0ZTogVGh1 LCAxIEp1bCAyMDIxIDExOjExOjA0ICswODAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3Byb2dt b2Rlcy9ndWQuZWw6IEhpZ2hsaWdodCBjdXJyZW50IGxpbmUKCi0tLQogbGlzcC9wcm9nbW9kZXMv Z3VkLmVsIHwgMTkgKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9ndWQuZWwgYi9saXNwL3Byb2dt b2Rlcy9ndWQuZWwKaW5kZXggNzQwYTZlMjU4MS4uNTdiYjYxMDI4NyAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMvZ3VkLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2d1ZC5lbApAQCAtODUsNiAr ODUsMTQgQEAgZ3VkCiAgIDpncm91cCAncHJvY2Vzc2VzCiAgIDpncm91cCAndG9vbHMpCiAKKyhk ZWZmYWNlIGd1ZC1oaWdobGlnaHQtZmFjZSAnKCh0ICg6aW5oZXJpdCBzZWNvbmRhcnktc2VsZWN0 aW9uKSkpCisgICJGYWNlIHRvIHVzZSB0byBoaWdobGlnaHQgY3VycmVudCBsaW5lLiIKKyAgOmdy b3VwICdndWQpCisKKyhkZWZjdXN0b20gZ3VkLWhpZ2hsaWdodC1saW5lIG5pbAorICAiSWYgbm9u LW5pbCwgaGlnaGxpZ2h0IHRoZSBjdXJyZW50IGxpbmUgd2hlbiBkZWJ1Z2dpbmcuIgorICA6Z3Jv dXAgJ2d1ZAorICA6dHlwZSAnYm9vbGVhbikKIAogKGRlZmN1c3RvbSBndWQta2V5LXByZWZpeCAi XEMteFxDLWEiCiAgICJQcmVmaXggb2YgYWxsIEdVRCBjb21tYW5kcyB2YWxpZCBpbiBDIGJ1ZmZl cnMuIgpAQCAtMjc2OCw2ICsyNzc2LDcgQEAgZ3VkLWZpbHRlcgogCSAgICAgIChndWQtZmlsdGVy IHByb2MgIiIpKSkpKSkKIAogKGRlZnZhciBndWQtbWlub3ItbW9kZS10eXBlIG5pbCkKKyhkZWZ2 YXIgZ3VkLW92ZXJsYXktbGluZSBuaWwpCiAoZGVmdmFyIGd1ZC1vdmVybGF5LWFycm93LXBvc2l0 aW9uIG5pbCkKIChhZGQtdG8tbGlzdCAnb3ZlcmxheS1hcnJvdy12YXJpYWJsZS1saXN0ICdndWQt b3ZlcmxheS1hcnJvdy1wb3NpdGlvbikKIApAQCAtMjc5MSw2ICsyODAwLDEwIEBAIGd1ZC1zZW50 aW5lbAogCSgobWVtcSAocHJvY2Vzcy1zdGF0dXMgcHJvYykgJyhzaWduYWwgZXhpdCkpCiAJIDs7 IFN0b3AgZGlzcGxheWluZyBhbiBhcnJvdyBpbiBhIHNvdXJjZSBmaWxlLgogCSAoc2V0cSBndWQt b3ZlcmxheS1hcnJvdy1wb3NpdGlvbiBuaWwpCisgICAgICAgICA7OyBTdG9wIGRpc3BsYXlpbmcg dGhlIGBndWQtb3ZlcmxheS1saW5lJy4KKyAgICAgICAgICh3aGVuIGd1ZC1oaWdobGlnaHQtbGlu ZQorICAgICAgICAgICAoZGVsZXRlLW92ZXJsYXkgZ3VkLW92ZXJsYXktbGluZSkKKyAgICAgICAg ICAgKHNldHEgZ3VkLW92ZXJsYXktbGluZSBuaWwpKQogCSAoaWYgKGVxIChidWZmZXItbG9jYWwt dmFsdWUgJ2d1ZC1taW5vci1tb2RlIGd1ZC1jb21pbnQtYnVmZmVyKQogCQkgICAnZ2RibWkpCiAJ ICAgICAoZ2RiLXJlc2V0KQpAQCAtMjg4Niw2ICsyODk5LDEyIEBAIGd1ZC1kaXNwbGF5LWxpbmUK IAkgIChvciBndWQtb3ZlcmxheS1hcnJvdy1wb3NpdGlvbgogCSAgICAgIChzZXRxIGd1ZC1vdmVy bGF5LWFycm93LXBvc2l0aW9uIChtYWtlLW1hcmtlcikpKQogCSAgKHNldC1tYXJrZXIgZ3VkLW92 ZXJsYXktYXJyb3ctcG9zaXRpb24gKHBvaW50KSAoY3VycmVudC1idWZmZXIpKQorICAgICAgICAg IDs7IFVwZGF0ZSB0aGUgcG9zaXRpb24gb2YgYGd1ZC1vdmVybGF5LWxpbmUnCisgICAgICAgICAg KHdoZW4gZ3VkLWhpZ2hsaWdodC1saW5lCisgICAgICAgICAgICAodW5sZXNzIGd1ZC1vdmVybGF5 LWxpbmUKKyAgICAgICAgICAgICAgKHNldHEgZ3VkLW92ZXJsYXktbGluZSAobWFrZS1vdmVybGF5 IChwb2ludCkgKHBvaW50KSkpCisgICAgICAgICAgICAgIChvdmVybGF5LXB1dCBndWQtb3Zlcmxh eS1saW5lICdmYWNlICdndWQtaGlnaGxpZ2h0LWZhY2UpKQorICAgICAgICAgICAgKG1vdmUtb3Zl cmxheSBndWQtb3ZlcmxheS1saW5lIChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikgKGxpbmUtZW5k LXBvc2l0aW9uKSAoY3VycmVudC1idWZmZXIpKSkKIAkgIDs7IElmIHRoZXkgdHVybmVkIG9uIGhs LWxpbmUsIG1vdmUgdGhlIGhsLWxpbmUgaGlnaGxpZ2h0IHRvCiAJICA7OyB0aGUgYXJyb3cncyBs aW5lLgogCSAgKHdoZW4gKGZlYXR1cmVwICdobC1saW5lKQotLSAKMi4zMC4xIChBcHBsZSBHaXQt MTMwKQoK --_004_851BB31A011B47A59B3C8878543C1533kuaishoucom_--