From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tobias Gerdin Newsgroups: gmane.emacs.devel Subject: Re: Keybinding for finding definition by mouse Date: Mon, 9 Jul 2018 22:40:33 +0200 Message-ID: <85166671-9551-cbe8-ee46-19f5996fbcd9@gmail.com> References: <76face16-e29e-e945-674f-79b8a2f2e498@gmail.com> <83h8l8gwte.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1531168756 21965 195.159.176.226 (9 Jul 2018 20:39:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2018 20:39:16 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 09 22:39:12 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fccwB-0005dS-Gl for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 22:39:11 +0200 Original-Received: from localhost ([::1]:44281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccyI-0002VC-HE for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 16:41:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccxd-0002V6-AS for emacs-devel@gnu.org; Mon, 09 Jul 2018 16:40:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fccxZ-0008DR-Up for emacs-devel@gnu.org; Mon, 09 Jul 2018 16:40:41 -0400 Original-Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:38009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fccxZ-0008D9-HD; Mon, 09 Jul 2018 16:40:37 -0400 Original-Received: by mail-lf0-x236.google.com with SMTP id a4-v6so16346722lff.5; Mon, 09 Jul 2018 13:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1FfjOP+DtezzczBoCpjhDlTDEw34SH/BpxUXLoPL9dk=; b=loCpmlfFz6jkRJ7lvRlSaXR3qYN264i7aTeqT7uwiDwtugNSEPh3/nyt9lzrY+X+7L 0WumaNh7UpgT7ULQP3QhjnkKSvWmVU9jB+aAJcZ6+VjF8ZPcTBDtFaP50SvHGIpc37R3 pQZEjFR6RvIXJeVdWohe3V2IG0SOjFgu6kb+DTERPw9ZF2Gp1miOQgCU2kTNqQzNID4D qcKsOEBkItkRIqhspisj6z5/9ZMEtmfBRtiXAdMLphZnOT5c1eSjSloEDIV8igISJMra jel5gGI0jOnN5wS8jCIOmGrLTebUf2G2/Z9xKXCJFsrVwWIYPsRRl3UfM5b1y3ROIG0h jTog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1FfjOP+DtezzczBoCpjhDlTDEw34SH/BpxUXLoPL9dk=; b=fQJjVGBXiCY3ffcQjYr8vYhO5X2ilmjlIMExddEkjV1plvRL/7nvQsI6aKmmuyPDD2 Imvexet/y1eAkW6DQ/losSJ/XyE+x+9aReVAbqhXZCXVJiCzP74Xx0oIZUVEju28CbaQ RO+RII5/LC0/OJoMDkPNmlGDBSqBN/J7bigjwLu7jsYs20td0XJv4xNuq0R34tpQSZq+ b2XybtFn/xM+3OpisMsvFD1mWsRj2G8H0d7WRPDM6uQEQKuKHXZbb9T7IJohOLCo9sj4 /zw3fcplu741LuAUmmrBG1wXglc6hRVIa2TuCKOimH+IDTL1qzIs373IU7W1R/mtvoCV Um5A== X-Gm-Message-State: APt69E2bwvP8UwyfHMj3sy7WynKXeDfCD5LEnWjSV+RcB1ESSxXatFru ywsunONAarAXuA4jlC1FCFqbVMQ5 X-Google-Smtp-Source: AAOMgpfnLko9Nji9jQjrWfgMJjHTPOTz3uRt9hdfClWE6dmQqX2caYQwXamp3q6+vkUTt48ltJimYQ== X-Received: by 2002:a19:a685:: with SMTP id p127-v6mr783128lfe.4.1531168835639; Mon, 09 Jul 2018 13:40:35 -0700 (PDT) Original-Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id a18-v6sm1079561ljk.47.2018.07.09.13.40.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 13:40:34 -0700 (PDT) In-Reply-To: <83h8l8gwte.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227183 Archived-At: Den 2018-07-09 kl. 19:09, skrev Eli Zaretskii: >> For mouse users like myself this invoking this is probably the second >> mouse common use of the mouse (after text selection) so I propose we add >> a default binding for it in the global map. So which one? > I wonder whether we should. I think people who like to use the mouse > for xref-find-definitions will bind the command to something handy, > like C-mouse-1 (and give up on, or rebind, mouse-buffer-menu). We > cannot do that by default, and OTOH binding it to something like > C-M-mouse-1 sounds too difficult to use (and then there's the problem > of binding xref-pop-marker-stack). > > I'm also not convinced many people will want such a binding, as most > of us use the keyboard for these commands. Could this not partly be because up until now Emacs didn't supply such commands? (although as of the CEDET merge there is actually 'semantic-ia-fast-mouse-jump' but since Emacs went in the xref direction I suspect few make use of it). And whether it is in one's interest to use the keyboard or the mouse for these kind of commands is still is an open question (among others, see [1]). My observation from co-workers seems to indicate that using the mouse for this kind of functionality is very common and I think having a default binding would improve its discoverability (although I am aware that this is hardly an area of focus in Emacs). > So I think we should leave this unbound by default, at least for now, > and rely on people who want this on a mouse click to make their local > changes. Unless any of the above makes you reconsider I will not argue against this. I have submitted a pull request for similar kind of functionality to CIDER ([2]) where we have decided to add a default binding along with it so I was hoping to harmonize these with Emacs' xref (which CIDER doesn't make use of at the moment), but CIDER being out-of-tree there is obviously more leeway. -Tobias [1]: https://news.ycombinator.com/item?id=14544571 [2]: https://github.com/clojure-emacs/cider/pull/2372