unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Gerdin <tgerdin@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Keybinding for finding definition by mouse
Date: Mon, 9 Jul 2018 22:40:33 +0200	[thread overview]
Message-ID: <85166671-9551-cbe8-ee46-19f5996fbcd9@gmail.com> (raw)
In-Reply-To: <83h8l8gwte.fsf@gnu.org>

Den 2018-07-09 kl. 19:09, skrev Eli Zaretskii:

>> For mouse users like myself this invoking this is probably the second
>> mouse common use of the mouse (after text selection) so I propose we add
>> a default binding for it in the global map. So which one?
> I wonder whether we should.  I think people who like to use the mouse
> for xref-find-definitions will bind the command to something handy,
> like C-mouse-1 (and give up on, or rebind, mouse-buffer-menu).  We
> cannot do that by default, and OTOH binding it to something like
> C-M-mouse-1 sounds too difficult to use (and then there's the problem
> of binding xref-pop-marker-stack).
>
> I'm also not convinced many people will want such a binding, as most
> of us use the keyboard for these commands.
Could this not partly be because up until now Emacs didn't supply such 
commands? (although as of the CEDET merge there is actually 
'semantic-ia-fast-mouse-jump' but since Emacs went in the xref direction 
I suspect few make use of it).

And whether it is in one's interest to use the keyboard or the mouse for 
these kind of commands is still is an open question (among others, see 
[1]). My observation from co-workers seems to indicate that using the 
mouse for this kind of functionality is very common and I think having a 
default binding would improve its discoverability (although I am aware 
that this is hardly an area of focus in Emacs).
> So I think we should leave this unbound by default, at least for now,
> and rely on people who want this on a mouse click to make their local
> changes.
Unless any of the above makes you reconsider I will not argue against 
this. I have submitted a pull request for similar kind of functionality 
to CIDER ([2]) where we have decided to add a default binding along with 
it so I was hoping to harmonize these with Emacs' xref (which CIDER 
doesn't make use of at the moment), but CIDER being out-of-tree there is 
obviously more leeway.

-Tobias
[1]: https://news.ycombinator.com/item?id=14544571
[2]: https://github.com/clojure-emacs/cider/pull/2372




  reply	other threads:[~2018-07-09 20:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-08 20:06 Keybinding for finding definition by mouse Tobias Gerdin
2018-07-09 17:09 ` Eli Zaretskii
2018-07-09 20:40   ` Tobias Gerdin [this message]
2018-07-10 16:16     ` Eli Zaretskii
2018-07-09 21:17   ` Tobias Gerdin
2018-07-09 17:43 ` Yuri Khan
2018-07-09 17:50   ` Marcin Borkowski
2018-07-09 18:42     ` Yuri Khan
2018-07-09 19:16       ` Helmut Eller
2018-07-09 19:58       ` Tobias Gerdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85166671-9551-cbe8-ee46-19f5996fbcd9@gmail.com \
    --to=tgerdin@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).