From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Antoine Kalmbach Newsgroups: gmane.emacs.devel Subject: Re: Supporting git-send-email/hg email in VC Date: Thu, 25 Aug 2022 11:36:55 +0300 Message-ID: <84y1vcn2hk.fsf@iki.fi> References: <848rndq2i7.fsf@iki.fi> <3E4E0239-22AA-4AB9-A092-3DC5404983C0@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Philip Kaluderdic , Stefan Monnier , Juri Linkov To: Sam James Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 25 11:27:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR99I-0009Oi-4t for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 11:27:40 +0200 Original-Received: from localhost ([::1]:43338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oR99H-0006Xx-12 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 05:27:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR8MH-0005X7-MJ for emacs-devel@gnu.org; Thu, 25 Aug 2022 04:37:03 -0400 Original-Received: from meesny.iki.fi ([195.140.195.201]:48298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR8ME-00006u-Rc for emacs-devel@gnu.org; Thu, 25 Aug 2022 04:37:00 -0400 Original-Received: from thanatos (91-157-197-22.elisa-laajakaista.fi [91.157.197.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ane) by meesny.iki.fi (Postfix) with ESMTPSA id 0F2742029B; Thu, 25 Aug 2022 11:36:56 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1661416616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7dfiCBmEwK8/32111hYYjIZ3O6OiTk5h6jA1dV5IN6g=; b=xokng8fqH3vBBB9pjZt/hIlRb2PnEcuKPmvkpXmrTh1L3ld6K81uIrymz8OChVR2ZPDxZG PdfZkj5eoKAnTHot+ZaPmbqdV1ZfHevc72udFfM+RQfhgvDhZsFCGOq28iVXobr0kWevei YEYfV+3TiSM2xPAW9a2ZC6K4OuRxvoc= In-Reply-To: <3E4E0239-22AA-4AB9-A092-3DC5404983C0@gentoo.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1661416616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7dfiCBmEwK8/32111hYYjIZ3O6OiTk5h6jA1dV5IN6g=; b=Kwl31inorgJxNi5nQ4pB9rmGZmTVaZbHSctB+k7Lt99akaz60R+aiE3sZA0A3qf++zdoDI 8JK6ZADalPIo41lNiuRtWHoDDP6AShyJttcyv9yP/jjziFQoX7ujx4jLWqK+995QV7hbQH oBCM/05MBZa67rQNByKUWD4IOa83znE= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=ane smtp.mailfrom=ane@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1661416616; a=rsa-sha256; cv=none; b=llNXStkKO/l0xNilByxqIFAy5jrB8uW0cYD2zM7JjiHRQ813SUfymCTO0YRoQqD81KBwBM FFqYatUiGK31iDrWQnfEH4IpgA/x/yRyM6Yhcm9Oku9C499eTwQnfYgTG7KdPHy68fuZAO GQVFV6mEKVd844E7QeC35ruf0wrY6Cw= Received-SPF: pass client-ip=195.140.195.201; envelope-from=ane@iki.fi; helo=meesny.iki.fi X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294078 Archived-At: It seems I wrote a bunch of replies off-list. Oops. Anyway, a summary of what I think are the conclusions. First, by relying only on git-format-patch to produce the emailsin the Git backend we should not be omitting any nuance that git-send-email has. Thus if we take the .patch file(s) directly and then open those in the MUA of the user, we won't do anything drastically different from git-email. The patches will by default be inline, though I suppose users could customize these to become attachments, but these won't obviously work with `git am`. Sam James writes: > Often, people are told to defer to git send-email because it definitely > does Things Right, but I haven't looked into the things it takes > care to do correctly. It might be easy for Emacs to do those. I will keep digging into this until I can be relatively confident about the differences. Looking at the source code and manuals it seems to me that git-format-patch is doing the heavy lifting and git-send-email is just a MUA on top of that. I mean, git-send-email accepts .patch files by git-format-patch as an argument, so it really appears just to be a MUA. But I need to be absolutely sure before proceeding. -- Antoine Kalmbach