From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: kai.grossjohann@gmx.net (=?iso-8859-1?q?Kai_Gro=DFjohann?=) Newsgroups: gmane.emacs.devel Subject: Re: Bug in Ange-FTP with renaming files Date: Sun, 06 Jul 2003 16:48:52 +0200 Organization: University of Duisburg, Germany Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <84n0frsobv.fsf@lucy.is.informatik.uni-duisburg.de> References: <84smpjsp77.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1057502989 20340 80.91.224.249 (6 Jul 2003 14:49:49 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2003 14:49:49 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jul 06 16:49:48 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19ZApo-0005Hw-00 for ; Sun, 06 Jul 2003 16:49:48 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19ZAzD-0004nT-00 for ; Sun, 06 Jul 2003 16:59:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZApk-0005VC-F0 for emacs-devel@quimby.gnus.org; Sun, 06 Jul 2003 10:49:44 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19ZApG-0004z1-7K for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:49:14 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19ZAp4-0004UT-SC for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:49:03 -0400 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZAp3-0004Tk-QE for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:49:01 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ZAoP-0005Cz-00 for ; Sun, 06 Jul 2003 16:48:21 +0200 Mail-Followup-To: emacs-devel@gnu.org X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ZAoN-0005Co-00 for ; Sun, 06 Jul 2003 16:48:19 +0200 Original-Lines: 30 Original-X-Complaints-To: usenet@main.gmane.org Mail-Copies-To: never User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:mcgjbpGQ0stIaXqaWaBIPsHrlgo= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15416 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15416 kai.grossjohann@gmx.net (Kai Großjohann) writes: > I shall try to investigate further, but I thought it would be good to > let you know -- more eyes find more bugs... Here is something fishy I found: after the last `R' command in dired, dired-rename-file calls dired-rename-subdir, but the args specified are not directories (see the second line in the following; /tmp/foo-kai/kais-file was the old name, /tmp/kais-file is the new name, and both are regular files): dired-fun-in-all-buffers("/ftp:kai@localhost:/tmp/foo-kai/kais-file/" nil dired-rename-subdir-1 "/ftp:kai@localhost:/tmp/foo-kai/kais-file/" "/ftp:kai@localhost:/tmp/kais-file/") dired-rename-subdir("/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file") dired-rename-file("/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file" nil) funcall(dired-rename-file "/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file" nil) (progn (funcall file-creator from to dired-overwrite-confirmed) (if overwrite (dired-remove-file to)) (setq success-count (1+ success-count)) (message "%s: %d of %d" operation success-count total) (dired-add-file to actual-marker-char)) (condition-case err (progn (funcall file-creator from to dired-overwrite-confirmed) (if overwrite ...) (setq success-count ...) (message "%s: %d of %d" operation success-count total) (dired-add-file to actual-marker-char)) (file-error (progn ... ...))) (let* ((overwrite ...) (dired-overwrite-confirmed ...) (actual-marker-char ...)) (condition-case err (progn ... ... ... ... ...) (file-error ...))) (if (not to) (setq skipped (cons ... skipped)) (let* (... ... ...) (condition-case err ... ...))) (lambda (from) (setq to (funcall name-constructor from)) (if (equal to from) (progn ... ...)) (if (not to) (setq skipped ...) (let* ... ...)))("/ftp:kai@localhost:/tmp/foo-kai/kais-file") mapcar((lambda (from) (setq to (funcall name-constructor from)) (if (equal to from) (progn ... ...)) (if (not to) (setq skipped ...) (let* ... ...))) ("/ftp:kai@localhost:/tmp/foo-kai/kais-file")) (let (to overwrite-query overwrite-backup-query) (mapcar (function ...) fn-list)) (let (failures skipped (success-count 0) (total ...)) (let (to overwrite-query overwrite-backup-query) (mapcar ... fn-list)) (cond (failures ...) (skipped ...) (t ...))) dired-create-files(dired-rename-file "Move" ("/ftp:kai@localhost:/tmp/foo-kai/kais-file") #[(from) "\302\303! \"\207" [from target expand-file-name file-name-nondirectory] 3] t) dired-do-create-files(move dired-rename-file "Move" nil t "Rename") dired-do-rename(nil) call-interactively(dired-do-rename) -- ~/.signature