From: kai.grossjohann@gmx.net (Kai Großjohann)
Subject: Re: Bug in Ange-FTP with renaming files
Date: Sun, 06 Jul 2003 16:48:52 +0200 [thread overview]
Message-ID: <84n0frsobv.fsf@lucy.is.informatik.uni-duisburg.de> (raw)
In-Reply-To: 84smpjsp77.fsf@lucy.is.informatik.uni-duisburg.de
kai.grossjohann@gmx.net (Kai Großjohann) writes:
> I shall try to investigate further, but I thought it would be good to
> let you know -- more eyes find more bugs...
Here is something fishy I found: after the last `R' command in dired,
dired-rename-file calls dired-rename-subdir, but the args specified
are not directories (see the second line in the following;
/tmp/foo-kai/kais-file was the old name, /tmp/kais-file is the new
name, and both are regular files):
dired-fun-in-all-buffers("/ftp:kai@localhost:/tmp/foo-kai/kais-file/" nil dired-rename-subdir-1 "/ftp:kai@localhost:/tmp/foo-kai/kais-file/" "/ftp:kai@localhost:/tmp/kais-file/")
dired-rename-subdir("/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file")
dired-rename-file("/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file" nil)
funcall(dired-rename-file "/ftp:kai@localhost:/tmp/foo-kai/kais-file" "/ftp:kai@localhost:/tmp/kais-file" nil)
(progn (funcall file-creator from to dired-overwrite-confirmed) (if overwrite (dired-remove-file to)) (setq success-count (1+ success-count)) (message "%s: %d of %d" operation success-count total) (dired-add-file to actual-marker-char))
(condition-case err (progn (funcall file-creator from to dired-overwrite-confirmed) (if overwrite ...) (setq success-count ...) (message "%s: %d of %d" operation success-count total) (dired-add-file to actual-marker-char)) (file-error (progn ... ...)))
(let* ((overwrite ...) (dired-overwrite-confirmed ...) (actual-marker-char ...)) (condition-case err (progn ... ... ... ... ...) (file-error ...)))
(if (not to) (setq skipped (cons ... skipped)) (let* (... ... ...) (condition-case err ... ...)))
(lambda (from) (setq to (funcall name-constructor from)) (if (equal to from) (progn ... ...)) (if (not to) (setq skipped ...) (let* ... ...)))("/ftp:kai@localhost:/tmp/foo-kai/kais-file")
mapcar((lambda (from) (setq to (funcall name-constructor from)) (if (equal to from) (progn ... ...)) (if (not to) (setq skipped ...) (let* ... ...))) ("/ftp:kai@localhost:/tmp/foo-kai/kais-file"))
(let (to overwrite-query overwrite-backup-query) (mapcar (function ...) fn-list))
(let (failures skipped (success-count 0) (total ...)) (let (to overwrite-query overwrite-backup-query) (mapcar ... fn-list)) (cond (failures ...) (skipped ...) (t ...)))
dired-create-files(dired-rename-file "Move" ("/ftp:kai@localhost:/tmp/foo-kai/kais-file") #[(from) "\302\303\b! \"\207" [from target expand-file-name file-name-nondirectory] 3] t)
dired-do-create-files(move dired-rename-file "Move" nil t "Rename")
dired-do-rename(nil)
call-interactively(dired-do-rename)
--
~/.signature
next prev parent reply other threads:[~2003-07-06 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-06 14:30 Bug in Ange-FTP with renaming files Kai Großjohann
2003-07-06 14:48 ` Kai Großjohann [this message]
2003-07-06 14:56 ` Kai Großjohann
2003-07-06 15:10 ` Kai Großjohann
2003-07-06 16:00 ` Kai Großjohann
2003-07-07 3:39 ` Richard Stallman
2003-07-07 5:58 ` Kai Großjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84n0frsobv.fsf@lucy.is.informatik.uni-duisburg.de \
--to=kai.grossjohann@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).