From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: kai.grossjohann@gmx.net (=?iso-8859-1?q?Kai_Gro=DFjohann?=) Newsgroups: gmane.emacs.devel Subject: Re: Bug in Ange-FTP with renaming files Date: Sun, 06 Jul 2003 16:56:34 +0200 Organization: University of Duisburg, Germany Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <84isqfsnz1.fsf@lucy.is.informatik.uni-duisburg.de> References: <84smpjsp77.fsf@lucy.is.informatik.uni-duisburg.de> <84n0frsobv.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1057503456 21990 80.91.224.249 (6 Jul 2003 14:57:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2003 14:57:36 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jul 06 16:57:35 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19ZAxL-0005iX-00 for ; Sun, 06 Jul 2003 16:57:35 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19ZB6l-0004sb-00 for ; Sun, 06 Jul 2003 17:07:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZAxc-00030p-AA for emacs-devel@quimby.gnus.org; Sun, 06 Jul 2003 10:57:52 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19ZAxF-0002rG-2D for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:57:29 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19ZAwg-000222-QW for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:56:55 -0400 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19ZAwT-0001oF-Ob for emacs-devel@gnu.org; Sun, 06 Jul 2003 10:56:41 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ZAvp-0005dA-00 for ; Sun, 06 Jul 2003 16:56:01 +0200 Mail-Followup-To: emacs-devel@gnu.org X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ZAvp-0005d0-00 for ; Sun, 06 Jul 2003 16:56:01 +0200 Original-Lines: 31 Original-X-Complaints-To: usenet@main.gmane.org Mail-Copies-To: never User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:oGw5IJrHrQLFpIE/GbStY1kYJcQ= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15417 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15417 kai.grossjohann@gmx.net (Kai Großjohann) writes: > kai.grossjohann@gmx.net (Kai Großjohann) writes: > >> I shall try to investigate further, but I thought it would be good to >> let you know -- more eyes find more bugs... > > Here is something fishy I found: after the last `R' command in dired, > dired-rename-file calls dired-rename-subdir, but the args specified > are not directories Right. This always happens: (defun dired-rename-file (file newname ok-if-already-exists) (dired-handle-overwrite newname) (rename-file file newname ok-if-already-exists) ; error is caught in -create-files ;; Silently rename the visited file of any buffer visiting this file. (and (get-file-buffer file) (with-current-buffer (get-file-buffer file) (set-visited-file-name newname nil t))) (dired-remove-file file) ;; See if it's an inserted subdir, and rename that, too. (dired-rename-subdir file newname)) Shouldn't dired-rename-subdir be conditioned on either file or newname being a directory? Or perhaps both? Or shouldn't dired-rename-subdir take care to do the right thing with non-directories? I'm getting confused now. -- ~/.signature