From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Tue, 28 Feb 2023 11:02:25 -0800 Message-ID: <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> References: <877h40vb8h.fsf@mail.jurta.org> <4EA4D31B.4050604@cs.ucla.edu> <4EA5E08D.8070903@cs.ucla.edu> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38327"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Robert Pluim , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 28 20:04:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX5Gg-0009o5-Dy for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Feb 2023 20:04:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pX5FI-0003bB-Ng; Tue, 28 Feb 2023 14:02:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX5F8-0003Z1-CW for emacs-devel@gnu.org; Tue, 28 Feb 2023 14:02:38 -0500 Original-Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX5F6-0001KG-P8; Tue, 28 Feb 2023 14:02:30 -0500 Original-Received: by mail-pl1-x629.google.com with SMTP id v11so7989399plz.8; Tue, 28 Feb 2023 11:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=F9orSPxMHhZ6sUl4XmEWENMiD9AeuQGFC8YDwf5AOVQ=; b=iIxBa0xOIhvHqR7YRdcMO6W4NTmAExuYZM2oJK0Fg8SM55hzGCPZm5sTB0S/m++B/v TvjEZ4Yt3ea8tP0HzA9aag2n8EUF/7cECYqEla0newnr3GjXRobiRjtuR4hcgU004nPI Q/PDj63VEWn/nggpwgnOgXtFT87zbeL02IzHYZJEZu4dafIZuQ/1vUR1bf7oVGXWX0U8 YfFVCg90/FC+lgiJlm5W5w7Wer3+xiq3VFhAk9duN9Pa26CnG30aQ6i0JIrpjFVE3KmK o0FtefOVRCjLr4hI9/PE2euad09CJf4brm8JYHK8xTrALgGUTTI3PMyuVDL2Bk7DkOS3 bZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F9orSPxMHhZ6sUl4XmEWENMiD9AeuQGFC8YDwf5AOVQ=; b=cFcCDVu5jddj5hUVmlqXNtlZSuLuEwqfUulvD+I/oSZWNRU51tJOqNtCtV+5fjMvbo nAZqTeRitjfIkTPbYDBPCxcAB5AFPEkP26PJZZyv7k/6q3LTAIfCSn+ZaPmbeu5Fez1j 1vWAp+txSirQf3UrbJ17DV8nmUng4msteuEPss3DLrHV1MzquufLIBqifLBW03rgQwr+ GJQ0hGpzsccZJunudKDs2RYrvYewtTuX80guzsEbdWsfjyd2Oty9LAywER2HQIrrMTTI NyNo04h1HoYYZaN3NbcJzkoLI3veLoY2kX/DXTz65dRYaf3gn4QkcwPHtsllPfX3wMIm 3gWw== X-Gm-Message-State: AO0yUKX2dxZ/HchNDQ8QN1RY3Y/31UAw1oTf8S6D0+1vj2Mg95dSsxWD RzHPOwnmR8D/lZb0EsjE9e8= X-Google-Smtp-Source: AK7set/G9QkOIr9P4ckJbcUi6g1/EVb5al41dICOcI0tcDJZxJet7y3b8UL9PAdaYI6L2oe9S22tHw== X-Received: by 2002:a17:90a:7ac6:b0:237:f8f9:8a2a with SMTP id b6-20020a17090a7ac600b00237f8f98a2amr4442253pjl.25.1677610946414; Tue, 28 Feb 2023 11:02:26 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u5-20020a17090a518500b00229bc852468sm8416749pjh.0.2023.02.28.11.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 11:02:25 -0800 (PST) Content-Language: en-US In-Reply-To: <87cz5uq6s1.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303865 Archived-At: On 2/28/2023 5:05 AM, Robert Pluim wrote: > Eli> Why does make-frame create a GUI X frame in a batch session? (I've > Eli> seen that in your previous backtrace, but thought it was because you > Eli> ran that test in an interactive session.) Ah ha, that's why I couldn't reproduce this. I usually run tests in an SSH session (most of my development work is in an isolated VM so I can throw it away if I mess something up really badly). Running within a GUI session, I see the error now. > The test does 'emacsclient -c', changing that to 'emacsclient -c -nw' > also makes the test succeed > > Eli> I don't think we should create GUI frames in batch, since the SIGIO > Eli> handler is not set, and we generally aren't prepared for receiving > Eli> it. We should create a TTY frame instead, or maybe no frame at all. > > I think the former would be better. Jim, since you wrote this test, > what do you think? We should definitely create a frame in these tests, since that's what the tests are trying to, well, test. (All the server tests are there to make sure that the usual things you might do with "emacsclient" work properly.) This might be a real bug in Emacs: as Eli says, an Emacs server started in batch mode shouldn't create GUI frames, but on the other hand, this might be only be relevant to the regression tests (who starts an Emacs server in a batch session?). I wouldn't mind just adding "-nw" to all the "emacsclient -c" invocations in server-tests.el.