From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Sat, 12 Nov 2022 07:16:40 +0100 Message-ID: <8464849C-0F41-40DE-8B7D-08CF37320362@thornhill.no> References: <87tu36em9t.fsf@thornhill.no> <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> <87v8nmyqqp.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16640"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 12 07:17:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otjpa-00046K-BY for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Nov 2022 07:17:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otjpK-0000P6-Nc; Sat, 12 Nov 2022 01:17:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otjpJ-0000Ox-54 for emacs-devel@gnu.org; Sat, 12 Nov 2022 01:17:13 -0500 Original-Received: from out2.migadu.com ([2001:41d0:2:aacc::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otjpG-0001hf-Do for emacs-devel@gnu.org; Sat, 12 Nov 2022 01:17:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668233826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QT+N17UB5ZynGYJymIqKtBHkycnsjXVcWevLN/wAgHI=; b=BThVSbLdGnse6ow01OUtSxN0yvoWYFg3dOpYfsqDltO63QMFn9YgK2YEEC1n2ZVzzxO4yz fOaoFIcX2VdGv7lYQmlmx2sYVg7Th0QMExE4B+RR9162XaFdNZY/FhS/SQXebV2uhiXqG0 NffOxYs7/59YuKycjkm30Xbl3RBQNo3pFoV+mJtNwfWEu6Xz+zzvJp1HQlJ38qAUVQqAdt EmIZP5QI1On3OupSlpcnwVJfGbT3SoKja2KMrSGXh3c5wEPsYmNZA7qu3qA2kHAX+foUeb +VOyjckIRC0J0+ue1gq+DLnfozQqXTbqoomO1Pb5Ip/3BZgNjmkllt5l4IGLWg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299610 Archived-At: On 12 November 2022 06:43:21 CET, Yuan Fu wrote: > > >> On Nov 10, 2022, at 10:01 PM, Theodor Thornhill w= rote: >>=20 >> Yuan Fu writes: >>=20 >>>> On Nov 10, 2022, at 9:45 AM, Theodor Thornhill = wrote: >>>>=20 >>>>=20 >>>>=20 >>>> Hi all, >>>>=20 >>>> See the attached patch for support for several C-like languages=2E >>>>=20 >>>> They all support: >>>> - Font locking >>>> - Indentation (with styles for c/c++) >>>> - Movement >>>> - Imenu >>>> - Which-func >>>>=20 >>>> These modes are meant as a supplement to tree-sitter=2E >>>>=20 >>>> I'm hopeful for some constructive criticism, and some testing=2E Thi= s >>>> patch needs to be applied to the feature/tree-sitter branch, and shou= ld >>>> hopefully be applied there before we merge the branch to master, well >>>> before Emacs 29 is cut=2E >>>>=20 >>>> I hope you like it, >>>>=20 >>>> Theo >>>=20 >>> This is fantastic! I=E2=80=99m trying them out right now :-) >>>=20 >>> Some things I noticed: >>>=20 >>> The indentation for the closing bracket of a struct is off: >>>=20 >>> struct regexp_cache >>> { >>> struct regexp_cache *next; >>> }; >>>=20 >>=20 >> Yeah=2E >>=20 >>> Imenu has some duplicate entries, the patch below should fix that=2E >>>=20 >>> I also added the new contextual thingy to font-lock settings=2E >>=20 >> Thanks, added! >>=20 >> See below patch=2E The struct issue was an ordering problem when I >> extracted the styles=2E Should be good now >>=20 >> Theo >>=20 >> <0001-Add-Tree-Sitter-modes-for-C-like-languages=2Epatch> > >I noticed that with the default indent style, Emacs indents like this: > >int main () { > for (int j =3D 0; j < 5; j++) > a[j] =3D 3; > int i =3D 1; > swap(i, a[i+1]); > Point p =3D {0, 1}; >} > >int main () >{ > for (int j =3D 0; j < 5; j++) > a[j] =3D 3; > int i =3D 1; > swap(i, a[i+1]); > Point p =3D {0, 1}; >} > >Is this expected? > >Yuan The first one isn't gnu style, right? But it's an easy fix :)