From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Date: Sun, 17 Dec 2017 16:39:13 -0800 Organization: UCLA Computer Science Department Message-ID: <84451444-be0f-2cbe-1e08-90c042c2c14b@cs.ucla.edu> References: <20171215073120.7671.79446@vcs0.savannah.gnu.org> <20171215073122.52703204D3@vcs0.savannah.gnu.org> <5A34119D.6000407@gmx.at> <5A34EA93.1050501@gmx.at> <9d0b9c22-d386-cd0a-3947-a44d58b1ee0e@cs.ucla.edu> <5A364B09.4020905@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1513557456 5544 195.159.176.226 (18 Dec 2017 00:37:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Dec 2017 00:37:36 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 To: martin rudalics , Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 18 01:37:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQjQx-00013k-Bj for ged-emacs-devel@m.gmane.org; Mon, 18 Dec 2017 01:37:31 +0100 Original-Received: from localhost ([::1]:56121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQjSv-00073T-Je for ged-emacs-devel@m.gmane.org; Sun, 17 Dec 2017 19:39:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQjSi-00073A-S8 for emacs-devel@gnu.org; Sun, 17 Dec 2017 19:39:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQjSe-0007SX-0l for emacs-devel@gnu.org; Sun, 17 Dec 2017 19:39:20 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eQjSd-0007Rt-QR for emacs-devel@gnu.org; Sun, 17 Dec 2017 19:39:15 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3C04C1613C1; Sun, 17 Dec 2017 16:39:14 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AyUCdJIEwoDo; Sun, 17 Dec 2017 16:39:13 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 81E9B16142D; Sun, 17 Dec 2017 16:39:13 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8N3zalVHe1pp; Sun, 17 Dec 2017 16:39:13 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5F1F61613B1; Sun, 17 Dec 2017 16:39:13 -0800 (PST) In-Reply-To: <5A364B09.4020905@gmx.at> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221199 Archived-At: martin rudalics wrote: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 eassume (CONSP (Vframe_list)); >=20 > now means that we can assume that `frame-list' is non-empty.=C2=A0 Isn'= t that > assumption incorrect in the scenario of the bug we're discussing here? Yes and no. The assumption is incorrect for this particular bug. But it i= s=20 correct for the two instances of eassume (CONSP (Vframe_list)) that I res= urrected. > > commit 8720f601e715e5f1d41f7cf863a525a1cc1bc12c > > removed these functions' assertions that frame-list is non-nil, so I > > thought it wise to resurrect them. >=20 > I don't think that these assertions did any good and would remove them > at least on master. Sounds good to me. Assertions that aren't useful for finding bugs are mor= e=20 trouble than they're worth. I kept them only because I didn't know the co= ntext well.