Make font menu available in menu bar

Make font menu available in menu bar

[Kai Großjohann]

It just occurred to me that the S-down-mouse-1 font menu should be
available in the menu bar somewhere.

Hm.  C-h k tells me it's already there.

Before that, I started searching under File, then Edit, then
Options.  But I didn't think to look under Mule.

WDYT about moving it outside of Options/Mule?  I'd expect to find it
either under Options or under Edit, though I'm not sure why I'd look
under Edit.  Maybe because other programs have an Edit/Preferences
menu item.

(I did look under Edit/Text Properties, interestingly enough.)
-- 
This line is not blank.

Re: Make font menu available in menu bar

[Richard Stallman]

    It just occurred to me that the S-down-mouse-1 font menu should be
    available in the menu bar somewhere.

    Hm.  C-h k tells me it's already there.

    Before that, I started searching under File, then Edit, then
    Options.  But I didn't think to look under Mule.

    WDYT about moving it outside of Options/Mule?  I'd expect to find it
    either under Options or under Edit, though I'm not sure why I'd look
    under Edit.

This is probably under Mule because it uses font sets, but I agree it
belongs in Edit.  I'd put it at directly under Edit, not in a submenu.

Would you like to move it?

Re: Make font menu available in menu bar

[Jason Rumney]

Richard Stallman wrote:

> This is probably under Mule because it uses font sets, but I agree it
> belongs in Edit.  I'd put it at directly under Edit, not in a submenu.

In what way is changing the default font "Edit"ing?

If we had a function to change the font of the text at point (or
selected text), then I agree it is a kind of Edit, but then it
should go under Text Properties. But changing the default font seems
more like an Option to me.

Re: Make font menu available in menu bar

[Richard Stallman]

    If we had a function to change the font of the text at point (or
    selected text), then I agree it is a kind of Edit, but then it
    should go under Text Properties. But changing the default font seems
    more like an Option to me.

That seems plausible.  Ok, I will put it directly under Options.
Having it under Mule does not make sense.

Re: Make font menu available in menu bar

[Kai Großjohann]

Richard Stallman <rms@gnu.org> writes:

> That seems plausible.  Ok, I will put it directly under Options.
> Having it under Mule does not make sense.

I've now done that.  I hope it was okay.

Index: lisp/international/mule-cmds.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/international/mule-cmds.el,v
retrieving revision 1.234
retrieving revision 1.235
diff -u -u -r1.234 -r1.235
--- lisp/international/mule-cmds.el	21 Jun 2003 02:26:58 -0000	1.234
+++ lisp/international/mule-cmds.el	27 Jun 2003 20:19:21 -0000	1.235
@@ -64,7 +64,7 @@
 (define-key-after mule-menu-keymap [set-language-environment]
   (list 'menu-item  "Set Language Environment" setup-language-environment-map
 	:help "Multilingual environment suitable for a specific language"))
-(define-key-after mule-menu-keymap [mouse-set-font]
+(define-key-after menu-bar-options-menu [mouse-set-font]
   '(menu-item "Set Font/Fontset" mouse-set-font
 	       :visible (fboundp 'generate-fontset-menu)
 	       :help "Select a font from list of known fonts/fontsets"))


-- 
~/.signature

Re: Make font menu available in menu bar

[Kevin Rodgers]

Kai Großjohann wrote:

> Richard Stallman <rms@gnu.org> writes:
>>That seems plausible.  Ok, I will put it directly under Options.
>>Having it under Mule does not make sense.
>>
> 
> I've now done that.  I hope it was okay.
> 
> Index: lisp/international/mule-cmds.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/international/mule-cmds.el,v
> retrieving revision 1.234
> retrieving revision 1.235
> diff -u -u -r1.234 -r1.235
> --- lisp/international/mule-cmds.el	21 Jun 2003 02:26:58 -0000	1.234
> +++ lisp/international/mule-cmds.el	27 Jun 2003 20:19:21 -0000	1.235
> @@ -64,7 +64,7 @@
>  (define-key-after mule-menu-keymap [set-language-environment]
>    (list 'menu-item  "Set Language Environment" setup-language-environment-map
>  	:help "Multilingual environment suitable for a specific language"))
> -(define-key-after mule-menu-keymap [mouse-set-font]
> +(define-key-after menu-bar-options-menu [mouse-set-font]
>    '(menu-item "Set Font/Fontset" mouse-set-font
>  	       :visible (fboundp 'generate-fontset-menu)
>  	       :help "Select a font from list of known fonts/fontsets"))

Why not move the whole (define-key-after ...) form to lisp/menu-bar.el, with

all the other references to menu-bar-options-menu?

-- 
<a href="mailto:&lt;kevin.rodgers&#64;ihs.com&gt;">Kevin Rodgers</a>

Re: Make font menu available in menu bar

[Kai Großjohann]

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> Why not move the whole (define-key-after ...) form to lisp/menu-bar.el, with
> all the other references to menu-bar-options-menu?

It seems my version didn't compile, and Richard fixed this by doing
what you suggested.  Thanks, Richard.

Sorry for the goof-up.
-- 
~/.signature