unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Raeburn <raeburn@raeburn.org>
Cc: emacs-devel@gnu.org
Subject: Re: Canonical location for emacs-version string in source tree?
Date: Fri, 21 May 2010 08:44:43 +0300	[thread overview]
Message-ID: <83zkztq050.fsf@gnu.org> (raw)
In-Reply-To: <32115842-89C0-4628-9523-C9C209FB4B0D@raeburn.org>

> From: Ken Raeburn <raeburn@raeburn.org>
> Date: Thu, 20 May 2010 21:39:53 -0400
> Cc: "Emacs Dev \[emacs-devel\]" <emacs-devel@gnu.org>
> 
> Making the C code aware of the version number seemed like the
> easiest way to deal with it.  I'm sorry about the problem with the
> MS-DOS build; I took this approach because I thought that it (unlike
> trying to generate all version-string appearances from one canonical
> source) would be a simple, relatively minor change with little
> impact on the DOS/Windows builds.

It _is_ with little impact, but the DOS build looks into version.el to
set $(version) in the top-level Makefile, which all the sub-Make's
then use.  You probably didn't think of grepping the files in the
msdos/ subdirectory when you looked for the effects of that change.  I
will fix this when I have time.

I don't expect anyone to know all those factoids, much less being an
expert on how the DOS port builds and works.  Just talking before
changes like that are made is good enough.



  reply	other threads:[~2010-05-21  5:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 16:57 Canonical location for emacs-version string in source tree? Jeff Kowalczyk
2010-05-20 17:12 ` Ken Raeburn
2010-05-20 18:01   ` Eli Zaretskii
2010-05-21  1:39     ` Ken Raeburn
2010-05-21  5:44       ` Eli Zaretskii [this message]
2010-05-21 20:19       ` Stefan Monnier
2010-05-21 21:33         ` Eli Zaretskii
2010-05-22  0:54           ` Stefan Monnier
2010-05-22  2:24             ` Ken Raeburn
2010-05-22 13:07               ` Stefan Monnier
2010-05-22  6:32             ` Eli Zaretskii
2010-05-22 16:03           ` Richard Stallman
2010-05-23 13:19             ` Stefan Monnier
2010-05-23 13:44               ` Lennart Borgman
2010-05-23 14:16               ` Drew Adams
2010-05-24 13:14                 ` Stefan Monnier
2010-05-24 13:57                   ` Drew Adams
2010-05-24 14:13                     ` Stefan Monnier
2010-05-24 14:25                       ` Drew Adams
2010-05-24 13:58                 ` Ken Raeburn
2010-05-24 14:16                   ` Stefan Monnier
2010-05-24 14:50                     ` Ken Raeburn
2010-05-24 14:21                   ` Drew Adams
2010-05-24 15:38               ` Richard Stallman
2010-05-24 17:44                 ` Stefan Monnier
2010-05-21  5:44     ` Ulrich Mueller
2010-05-20 19:57   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zkztq050.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=raeburn@raeburn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).