From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Header lines of commit messages Date: Thu, 01 Jul 2010 00:08:51 +0300 Message-ID: <83zkyc9qjg.fsf@gnu.org> References: <83r5jucbvq.fsf@gnu.org> <87k4pldikb.fsf@elegiac.orebokech.com> <87hbkpn8d4.fsf@uwakimon.sk.tsukuba.ac.jp> <83eiftddbj.fsf@gnu.org> <87eiftn2lm.fsf@uwakimon.sk.tsukuba.ac.jp> <838w61d5gs.fsf@gnu.org> <87aaqc9xlu.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1277932043 22180 80.91.229.12 (30 Jun 2010 21:07:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Jun 2010 21:07:23 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 30 23:07:20 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OU4V5-000461-7d for ged-emacs-devel@m.gmane.org; Wed, 30 Jun 2010 23:07:19 +0200 Original-Received: from localhost ([127.0.0.1]:40265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OU4V4-0000zr-O1 for ged-emacs-devel@m.gmane.org; Wed, 30 Jun 2010 17:07:18 -0400 Original-Received: from [140.186.70.92] (port=60032 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OU4Uw-0000z6-WB for emacs-devel@gnu.org; Wed, 30 Jun 2010 17:07:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OU4Ur-00056s-TB for emacs-devel@gnu.org; Wed, 30 Jun 2010 17:07:10 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57684) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU4Ur-0004ul-Lc for emacs-devel@gnu.org; Wed, 30 Jun 2010 17:07:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L4U00L00IFWU600@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 01 Jul 2010 00:06:45 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.12.240]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L4U00IYOIN87P80@a-mtaout22.012.net.il>; Thu, 01 Jul 2010 00:06:45 +0300 (IDT) In-reply-to: <87aaqc9xlu.fsf@lifelogs.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126554 gmane.emacs.gnus.general:69769 Archived-At: > From: Ted Zlatanov > Date: Wed, 30 Jun 2010 13:36:13 -0500 > Cc: ding@gnus.org > > On Sat, 26 Jun 2010 21:16:51 +0300 Eli Zaretskii wrote: > > EZ> In the Gnus case, I'd prefer more meaningful headers as well, but it's > EZ> hard to ask for that when a large body of unrelated changes is > EZ> delivered to Emacs at once. > > Katsumi Yamaoka has been doing the synchronization so far. Let him and > the other Gnus developers know if there's a problem with the > synchronization log messages. As long as you are committing to the Emacs repository many unrelated changes, there really is no way of making the commit messages more useful. But at least in several cases, it looks like the committed changes belong to a single changeset. Examples: revno: 100593 committer: Romain Francoise branch nick: trunk timestamp: Sat 2010-06-12 19:26:40 +0200 message: Synch with Gnus trunk. * gnus-util.el (gnus-date-get-time): Move up before first use. ------------------------------------------------------------ revno: 100575 [merge] committer: Katsumi Yamaoka branch nick: trunk timestamp: Thu 2010-06-10 05:54:25 +0000 message: Synch with Gnus trunk. (gnus-mime-buttonized-part-id): New internal variable. (gnus-article-edit-part): Bind it to make last part that is substituted or deleted visible. (gnus-mime-display-single): Buttonize part of which id equals to gnus-mime-buttonized-part-id. ------------------------------------------------------------ revno: 100564 [merge] committer: Katsumi Yamaoka branch nick: trunk timestamp: Thu 2010-06-10 00:31:03 +0000 message: Synch with Gnus trunk. 2010-06-10 Dan Christensen * gnus-util.el (gnus-user-date): Use gnus-date-get-time. (gnus-dd-mmm): Use gnus-date-get-time. * gnus-sum.el (gnus-thread-latest-date): Use gnus-date-get-time and simplify logic. (gnus-summary-limit-to-age): Use gnus-date-get-time. (gnus-sort-threads): emit message if gnus-sort-threads-loop used. ------------------------------------------------------------ For such changes, it would be more useful if the first line of the commit message summarized the change, instead of saying just "Synch with Gnus trunk". That would allow to, e.g., find the merge which introduced some specific change in Gnus by just looking at the output of "bzr log --line", which shows only those first lines from the commit messages. > I plan to eventually set up a more automatic synchronization method. Thanks. For that, I hope the original commit message would become the commit message in the Bazaar repository. > >> If you really *do* want to know about irrelevant commits, I don't > >> understand why you find it acceptable that Gnus doesn't rebase its > >> synchs into the mainline. > > EZ> Because I'm too old to fight Quixotic battles. And because people who > EZ> do the job should have some leeway in determining how far they want to > EZ> go towards the project to which they contribute. If Stefan and Yidong > EZ> can live with what Gnus maintainers do when they synch, so can I. > > Sorry, I am not clear on the problem, though it's probably obvious to > you. Can you explain what's the problem and what we can do on the Gnus > side to remedy it? Only what I ask above regarding the first line of the commit messages.