unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Buffer size limitation in insdel.c
Date: Wed, 22 Sep 2010 17:20:48 +0200	[thread overview]
Message-ID: <83zkv9vm7j.fsf@gnu.org> (raw)
In-Reply-To: <m3hbhi2d0t.fsf@quimbies.gnus.org>

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 22 Sep 2010 14:12:02 +0200
> 
> >   { EMACS_INT total_size = Z_BYTE - BEG_BYTE + GAP_SIZE + nbytes_added;
> >     if (total_size < 0
> > 	/* Don't allow a buffer size that won't fit in a Lisp integer.  */
> > 	|| total_size != XINT (make_number (total_size))
> > 	/* Don't allow a buffer size that won't fit in an int
> > 	   even if it will fit in a Lisp integer.
> > 	   That won't work because so many places still use `int'.  */
> > 	|| total_size != (EMACS_INT) (int) total_size)
> >       error ("Buffer exceeds maximum size");
> >
> > "bzr annotate" says this was committed a year ago by Stefan.
> >
> > Any objections to removing this limitation on 64-bit machines?
> 
> If you saw my experiment with -Wconversion, we have 5400 potential type
> conversion errors, where a lot (a *lot*) of them involved EMACS_INT/int
> confusion, and a lot of those were buffer-related.
> 
> So until that's fixed, I think it's a valid limitation.  Emacs is
> probably just going to segfault if you load a buffer that's bigger than
> (er) 2GB.

Then why do other places that bitch about buffer size being exceeded
don't do the same?



  reply	other threads:[~2010-09-22 15:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 12:06 Buffer size limitation in insdel.c Eli Zaretskii
2010-09-22 12:12 ` Lars Magne Ingebrigtsen
2010-09-22 15:20   ` Eli Zaretskii [this message]
2010-09-22 12:16 ` David Kastrup
2010-09-23  0:06 ` Stefan Monnier
2010-09-23  0:58 ` Richard Stallman
2010-09-23  7:55   ` Eli Zaretskii
2010-09-23  9:23     ` Leo
2010-09-23  9:30       ` Eli Zaretskii
2010-09-23 10:59     ` Lars Magne Ingebrigtsen
2010-09-23 12:15       ` Eli Zaretskii
2010-09-23 12:18         ` Lars Magne Ingebrigtsen
2010-09-23 12:47           ` Lars Magne Ingebrigtsen
2010-09-23 13:12             ` Andreas Schwab
2010-09-23 13:22             ` Eli Zaretskii
2010-09-23 13:37               ` Lars Magne Ingebrigtsen
2010-09-23 14:13                 ` Eli Zaretskii
2010-09-23 14:21                   ` Lars Magne Ingebrigtsen
2010-09-23 14:31                     ` Lars Magne Ingebrigtsen
2010-09-23 14:41                     ` Eli Zaretskii
2010-09-23 14:49                       ` Lars Magne Ingebrigtsen
2010-09-23 15:08                         ` Lars Magne Ingebrigtsen
2010-09-23 18:56                         ` Eli Zaretskii
2010-09-23 19:02                           ` Lars Magne Ingebrigtsen
2010-09-23 19:22                             ` Eli Zaretskii
2010-09-24 14:09     ` Richard Stallman
2010-09-24 14:28       ` Eli Zaretskii
2010-09-24 14:38         ` Lars Magne Ingebrigtsen
2010-09-25 13:55           ` Eli Zaretskii
2010-09-25 16:26             ` Lars Magne Ingebrigtsen
2010-09-25 16:38               ` Lars Magne Ingebrigtsen
2010-09-25  9:40         ` Richard Stallman
2010-09-25 10:00           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zkv9vm7j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).