From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Generating byteswap.h on Windows Date: Fri, 04 Oct 2013 17:09:31 +0300 Message-ID: <83zjqpb010.fsf@gnu.org> References: <524E9166.8090408@gmx.at> <8338ohcnn3.fsf@gnu.org> <524EB8EA.8040707@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1380895804 31102 80.91.229.3 (4 Oct 2013 14:10:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Oct 2013 14:10:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 04 16:10:07 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VS64x-000526-Lr for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 16:10:03 +0200 Original-Received: from localhost ([::1]:48211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS64x-0008JP-4m for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 10:10:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS64n-0008Ba-Fk for emacs-devel@gnu.org; Fri, 04 Oct 2013 10:09:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS64f-00058V-PP for emacs-devel@gnu.org; Fri, 04 Oct 2013 10:09:53 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:44350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS64f-00058H-Hi for emacs-devel@gnu.org; Fri, 04 Oct 2013 10:09:45 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MU500B00CUSAT00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 04 Oct 2013 17:09:43 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MU500B9FE07FQ10@a-mtaout20.012.net.il>; Fri, 04 Oct 2013 17:09:43 +0300 (IDT) In-reply-to: <524EB8EA.8040707@gmx.at> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163847 Archived-At: > Date: Fri, 04 Oct 2013 14:47:38 +0200 > From: martin rudalics > CC: emacs-devel@gnu.org > > > Why leave it to me? > > Because as a rule I only install changes I understand and I don't > understand makefiles. If the build was broken, and your change fixes it, the fix is worth installing, so that others could build successfully. We can always improve the fix later, if needed. IOW, installing a fix can never make things worse than they are when the build is broken. > Moreover I now have byteswap.h in my lib directory and according to > bzr status I would commit that too. So I'd also have to learn how > to avoid that. You can "bzr commit" specific files. But the general rule for this is add the file to .bzrignore. > > Please install whatever changes you find that fix > > any breakage. > > If you can't commit I can do it but at least give me some sort of > approval first that Paul's patch is correct. You will always have my approval for committing something that fixes a broken build. I just don't want that it will always depend on me, because I'm sometimes busy or unavailable. Thanks.