From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: sdl.web@gmail.com, emacs-devel@gnu.org
Subject: Re: Eldoc mode in eval-minibuffer
Date: Mon, 20 Jan 2014 21:25:10 +0200 [thread overview]
Message-ID: <83zjmqh2w9.fsf@gnu.org> (raw)
In-Reply-To: <jwvfvoi8rqa.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org
> Date: Mon, 20 Jan 2014 12:59:26 -0500
>
> > Besides the usual gripes about such prominent changes in behavior
> > being made during feature freeze,
>
> I don't know of such a change. AFAIK the change to eldoc installed
> recently was about changing the implementation of
> eldoc-post-insert-mode, to make it more like the normal eldoc mode.
> I.e. a change in implementation more than in behavior.
>
> > . Since it is not in NEWS, chances are it will never get mentioned in
> > the manual, which is bad for default behavior.
>
> IIUC this change in behavior was not intended.
>
> Leo, can you take a look to see what's going on?
This part of r115987 does it:
=== modified file 'lisp/simple.el'
--- lisp/simple.el 2014-01-09 01:59:19 +0000
+++ lisp/simple.el 2014-01-12 04:00:03 +0000
@@ -1387,6 +1387,7 @@ display the result of expression evaluat
(lambda ()
(add-hook 'completion-at-point-functions
#'lisp-completion-at-point nil t)
+ (eldoc-mode 1)
(run-hooks 'eval-expression-minibuffer-setup-hook))
(read-from-minibuffer prompt initial-contents
read-expression-map t
next prev parent reply other threads:[~2014-01-20 19:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 16:02 Eldoc mode in eval-minibuffer Eli Zaretskii
2014-01-20 17:48 ` Thierry Volpiatto
2014-01-21 1:23 ` Leo Liu
2014-01-21 1:42 ` Leo Liu
2014-01-21 9:52 ` Thierry Volpiatto
2014-01-21 13:41 ` Stefan Monnier
2014-01-21 13:35 ` Stefan Monnier
2014-01-20 17:59 ` Stefan Monnier
2014-01-20 19:25 ` Eli Zaretskii [this message]
2014-01-20 19:47 ` Glenn Morris
2014-01-21 1:32 ` Leo Liu
2014-01-21 2:05 ` Stefan Monnier
2014-01-21 2:24 ` Leo Liu
2014-01-22 10:28 ` Darren Hoo
2014-01-22 13:41 ` Stefan Monnier
2014-01-21 3:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zjmqh2w9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).