From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Thu, 23 Jan 2014 18:02:09 +0200 Message-ID: <83zjmmelfi.fsf@gnu.org> References: <8361pbg5vy.fsf@gnu.org> <87ha8vn6dg.fsf@fencepost.gnu.org> <834n4vg4r1.fsf@gnu.org> <52E08DA6.6040600@cs.ucla.edu> <831tzzfj5g.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390492928 5039 80.91.229.3 (23 Jan 2014 16:02:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jan 2014 16:02:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 23 17:02:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6MjH-00045G-U4 for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 17:02:08 +0100 Original-Received: from localhost ([::1]:41969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6MjH-0002tc-Ix for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 11:02:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6MjA-0002s5-3w for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:02:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Mj4-0002Um-78 for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:02:00 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:36749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Mj3-0002UU-V6 for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:01:54 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0MZV00B002W3LY00@mtaout27.012.net.il> for emacs-devel@gnu.org; Thu, 23 Jan 2014 18:01:14 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZV004VM361US70@mtaout27.012.net.il>; Thu, 23 Jan 2014 18:01:13 +0200 (IST) In-reply-to: <831tzzfj5g.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168957 Archived-At: > Date: Thu, 23 Jan 2014 05:53:47 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > Date: Wed, 22 Jan 2014 19:33:58 -0800 > > From: Paul Eggert > > > > This problem isn't limited to update-game-score. I found three other > > instances in Emacs. The first was in qcopy_acl (called by Fcopy_file) > > and I fixed it in trunk bzr 116124. The other two are in fileio.c and > > filelock.c. The attached patch should fix it; I plan to install it > > unless someone points out a problem with it. > > Please don't install this, we've been living with this "problem" long > enough to leave it for afterwards. And on top of that, it would break the Windows build, because gnulib functions called by Emacs can no longer call libc functions that accept file names, since we now pass UTF-8 encoded file names to them. So where formerly fchmod was a no-op that always succeeded, fnchmod will now be a no-op that always fails, and filelock.c will stop working.