From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Font height issue
Date: Thu, 25 Feb 2016 22:04:21 +0200 [thread overview]
Message-ID: <83ziuoeeuy.fsf@gnu.org> (raw)
In-Reply-To: <87oab4fusj.fsf@gnu.org> (message from Tassilo Horn on Thu, 25 Feb 2016 20:34:52 +0100)
> From: Tassilo Horn <tsdh@gnu.org>
> Date: Thu, 25 Feb 2016 20:34:52 +0100
>
> I have the problem that the font I want to use in Emacs (PragmataPro in
> size 10, sizes 9 or 11 seem to be not affected) seems to have slightly
> different heights in the regular and the bold version, or at least Emacs
> thinks so. As a result, when modes change text to/from regular to bold
> or vice versa dynamically (e.g., show-paren-mode with a bold
> show-paren-match face), the height of the line changes which is
> extremely annoying.
>
> When I searched the net I found many others having this kind of issue
> with different fonts (like DejaVu Sans Mono), too, and I also found this
> workaround
>
> https://www.reddit.com/r/emacs/comments/3zto22/i_sort_of_fixed_a_font_rendering_bug_of_emacs/
>
> suggesting this patch:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/src/xftfont.c b/src/xftfont.c
> index 110f99a..95e7e52 100644
> --- a/src/xftfont.c
> +++ b/src/xftfont.c
> @@ -395,16 +395,16 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
>
> font->ascent = xftfont->ascent;
> font->descent = xftfont->descent;
> - if (pixel_size >= 5)
> - {
> - /* The above condition is a dirty workaround because
> - XftTextExtents8 behaves strangely for some fonts
> - (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. */
> - if (font->ascent < extents.y)
> - font->ascent = extents.y;
> - if (font->descent < extents.height - extents.y)
> - font->descent = extents.height - extents.y;
> - }
> + /* if (pixel_size >= 5) */
> + /* { */
> + /* /\* The above condition is a dirty workaround because */
> + /* XftTextExtents8 behaves strangely for some fonts */
> + /* (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. *\/ */
> + /* if (font->ascent < extents.y) */
> + /* font->ascent = extents.y; */
> + /* if (font->descent < extents.height - extents.y) */
> + /* font->descent = extents.height - extents.y; */
> + /* } */
> font->height = font->ascent + font->descent;
>
> if (XINT (AREF (entity, FONT_SIZE_INDEX)) == 0)
> --8<---------------cut here---------------end--------------->8---
>
> And indeed, that does solve the issue for me. Now the regular and the
> bold version are displayed with the same height.
Sorry, this is bug #22383, where the conclusion was already reached
that the workaround was not needed anymore. I thought the change was
committed, but I see that it wasn't, so I committed it now to the
emacs-25 branch.
next prev parent reply other threads:[~2016-02-25 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 19:34 Font height issue Tassilo Horn
2016-02-25 19:49 ` Marcin Borkowski
2016-02-25 20:04 ` Eli Zaretskii [this message]
2016-02-25 20:07 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ziuoeeuy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).