From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: FACE_FROM_ID vs FACE_OPT_FROM_ID Date: Fri, 24 Jun 2016 13:00:02 +0300 Message-ID: <83ziqa29gd.fsf@gnu.org> References: <83d1n73c5z.fsf@gnu.org> <576C7D75.4070401@cs.ucla.edu> <8360sz2cpc.fsf@gnu.org> <576CFCFE.8050908@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466764313 31830 80.91.229.3 (24 Jun 2016 10:31:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 10:31:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 24 12:31:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGOOt-0006Xu-Bu for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2016 12:31:51 +0200 Original-Received: from localhost ([::1]:42458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGOOs-0002ck-MX for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2016 06:31:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNut-0001eK-M7 for emacs-devel@gnu.org; Fri, 24 Jun 2016 06:00:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGNup-0005BP-Eq for emacs-devel@gnu.org; Fri, 24 Jun 2016 06:00:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNup-0005BL-BK; Fri, 24 Jun 2016 06:00:47 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3886 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGNuo-0005Xk-F0; Fri, 24 Jun 2016 06:00:46 -0400 In-reply-to: <576CFCFE.8050908@cs.ucla.edu> (message from Paul Eggert on Fri, 24 Jun 2016 11:27:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204723 Archived-At: [Please ignore the previous message, it was confused.] > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Fri, 24 Jun 2016 11:27:26 +0200 > > > eassert (face); if (!face) { ...} > > eassert (X) means that X must be nonzero, so there should never be a > need for a runtime check !X after a call to eassert (X). Maybe I'm missing something, but my reading of this: #ifndef ENABLE_CHECKING # define eassert(cond) ((void) (false && (cond))) /* Check COND compiles. */ is that when ENABLE_CHECKING is not defined, eassert does nothing useful.