From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Advice needed on modeline customization hack... Date: Mon, 17 Apr 2017 09:00:24 +0300 Message-ID: <83ziffefpj.fsf@gnu.org> References: <20170415212800.5be89037@jabberwock.cb.piermont.com> <20170416094929.51e94c82@jabberwock.cb.piermont.com> <20170416104633.1768bbb6@jabberwock.cb.piermont.com> <20170416120942.36af8967@jabberwock.cb.piermont.com> <20170416180620.3615b4b6@jabberwock.cb.piermont.com> <20170416181607.4ca1971e@jabberwock.cb.piermont.com> <20170416185740.7d848393@jabberwock.cb.piermont.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492408803 9366 195.159.176.226 (17 Apr 2017 06:00:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 06:00:03 +0000 (UTC) Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Perry E. Metzger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 07:59:58 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czzhd-0002JH-Qn for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 07:59:57 +0200 Original-Received: from localhost ([::1]:34959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czzhj-0001fl-SH for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 02:00:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czzhe-0001fg-5o for emacs-devel@gnu.org; Mon, 17 Apr 2017 01:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czzha-0000io-48 for emacs-devel@gnu.org; Mon, 17 Apr 2017 01:59:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czzha-0000ik-0m; Mon, 17 Apr 2017 01:59:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4804 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1czzhY-0003Ks-Sy; Mon, 17 Apr 2017 01:59:53 -0400 In-reply-to: <20170416185740.7d848393@jabberwock.cb.piermont.com> (perry@piermont.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214043 Archived-At: > Date: Sun, 16 Apr 2017 18:57:40 -0400 > From: "Perry E. Metzger" > Cc: Stefan Monnier , emacs-devel@gnu.org > > Attached is an improved patch, including documentation changes. Thanks. Allow me a few comments below. > Comments solicited. I'm not fond of the name > "column-number-mode-starts-from-zero" by the way. How about column-number-indicator-zero-based instead? > +@vindex column-number-mode-starts-from-zero > + In Column Number mode, the displayed column number begins at zero at > +the start of a line. If you would prefer for the displayed column > +number to begin at one, you may set > +@code{column-number-mode-starts-from-zero} to @code{nil}. The first sentence is ambiguous with the current bidirectional display, because "start of line" is ambiguous. I suggest to use the wording with which we describe current-column: ... the displayed column number counts from 0 at the left margin of the window. I also think that using digits 0 and 1 is better than using the words, but that's my personal preference, so if you feel strongly about using words, I won't object. Also, please leave 2 spaces between sentences, as we use the US English conventions in our documentation. > @item %c > -The current column number of point. > +The current column number of point, starting from zero. > + > +@item %C > +The current column number of point, starting from one. I think "zero-based" and "one-based" is better. Or maybe include a more detailed description of how the column is counted. Please also add a NEWS entry about this new option. > diff --git a/lisp/simple.el b/lisp/simple.el > index 5f70adedc4..821880b1f3 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -7198,6 +7198,10 @@ column-number-mode > If called from Lisp, enable the mode if ARG is omitted or nil." > :global t :group 'mode-line) > > +(defvar column-number-mode-starts-from-zero t > + "When set to true, Column Number mode displays columns starting from zero. > +Otherwise, displayed column numbers start from one.") This should be a defcustom, not defvar. I think it's best to have it in xdisp.c, where the feature is implemented, in which case you should add the necessary stuff to cus-start.el to allow its customization by Custom. What about the required change to mode_line_update_needed?