From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document'
Date: Sun, 17 Dec 2017 22:22:34 +0200 [thread overview]
Message-ID: <83zi6hp0j9.fsf@gnu.org> (raw)
In-Reply-To: <5A36AF3D.8040406@gmx.at> (message from martin rudalics on Sun, 17 Dec 2017 18:54:05 +0100)
> Date: Sun, 17 Dec 2017 18:54:05 +0100
> From: martin rudalics <rudalics@gmx.at>
> Cc: emacs-devel@gnu.org
>
> (if (not (get-buffer-window (current-buffer)))
> (let ((window-point (window-point)))
> (prog1
> (save-window-excursion
> ;; Avoid errors if the selected window is a dedicated one,
> ;; and they just want to insert a document into it.
> (set-window-dedicated-p nil nil)
> (set-window-buffer nil (current-buffer))
> (car (window-text-pixel-size nil (line-beginning-position) (point))))
> (set-window-point nil window-point)))
If we do that, then why use save-window-excursion in the first place?
That's what it's supposed to preserve (among other things), right?
If it doesn't do that much, let's do its job by hand altogether. (And
then, of course, a few years down the line someone will come and ask
herself why don't they just use save-window-excursion.)
next prev parent reply other threads:[~2017-12-17 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171216141055.30854.67661@vcs0.savannah.gnu.org>
[not found] ` <20171216141056.8391A24612@vcs0.savannah.gnu.org>
2017-12-16 15:04 ` [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Stefan Monnier
2017-12-16 16:04 ` Eli Zaretskii
2017-12-16 22:23 ` Stefan Monnier
2017-12-17 15:44 ` Eli Zaretskii
2017-12-17 17:54 ` martin rudalics
2017-12-17 20:22 ` Eli Zaretskii [this message]
2017-12-17 21:20 ` martin rudalics
2017-12-18 3:09 ` Stefan Monnier
2017-12-18 7:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi6hp0j9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).