unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, emacs-devel@gnu.org
Subject: Re: [PATCH 1/2] Use Jansson's error code support if available
Date: Tue, 19 Dec 2017 19:11:05 +0200	[thread overview]
Message-ID: <83zi6eod7a.fsf@gnu.org> (raw)
In-Reply-To: <20171218231730.38840-1-phst@google.com> (message from Philipp Stephani on Tue, 19 Dec 2017 00:17:29 +0100)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Tue, 19 Dec 2017 00:17:29 +0100
> Cc: Philipp Stephani <phst@google.com>
> 
> * src/json.c (json_parse_error): Use Jansson's error code support if
> available.
> ---
>  src/json.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/src/json.c b/src/json.c
> index 29e4400fc9..b996cad5a6 100644
> --- a/src/json.c
> +++ b/src/json.c
> @@ -249,15 +249,24 @@ static _Noreturn void
>  json_parse_error (const json_error_t *error)
>  {
>    Lisp_Object symbol;
> -  /* FIXME: Upstream Jansson should have a way to return error codes
> -     without parsing the error messages.  See
> -     https://github.com/akheron/jansson/issues/352.  */
> +#if JANSSON_VERSION_HEX >= 0x020B00
> +  switch (json_error_code (error))

Would it be possible for you to add the few lines which would make
this work on MS-Windows?  It's pretty much boilerplate (you can see
what I did for every jansson function we need, and copycat that), but
if you don't add those few lines, the Windows build will fail to link.

TIA



  parent reply	other threads:[~2017-12-19 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 23:17 [PATCH 1/2] Use Jansson's error code support if available Philipp Stephani
2017-12-18 23:17 ` [PATCH 2/2] JSON serialization: reject duplicate keys in hashtables Philipp Stephani
2017-12-24 12:53   ` Philipp Stephani
2017-12-19 17:11 ` Eli Zaretskii [this message]
2017-12-19 17:35   ` [PATCH 1/2] Use Jansson's error code support if available Philipp Stephani
2017-12-19 19:54     ` Eli Zaretskii
2017-12-19 21:49       ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zi6eod7a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).