From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: No support for ImageMagick 7 in emacs-26 Date: Mon, 26 Nov 2018 19:38:02 +0200 Message-ID: <83zhtvhh8l.fsf@gnu.org> References: <83efb9jf7x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1543253760 22408 195.159.176.226 (26 Nov 2018 17:36:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Nov 2018 17:36:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 26 18:35:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRKnc-0005ja-9A for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2018 18:35:56 +0100 Original-Received: from localhost ([::1]:38001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKpi-00032a-JX for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2018 12:38:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKpc-000328-KB for emacs-devel@gnu.org; Mon, 26 Nov 2018 12:38:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRKpY-0003Ly-Jb for emacs-devel@gnu.org; Mon, 26 Nov 2018 12:38:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKpY-0003Ll-D3; Mon, 26 Nov 2018 12:37:56 -0500 Original-Received: from [176.228.60.248] (port=2450 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRKpY-0003xR-0d; Mon, 26 Nov 2018 12:37:56 -0500 In-reply-to: (message from Ulrich Mueller on Mon, 26 Nov 2018 08:38:21 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231401 Archived-At: > From: Ulrich Mueller > Cc: emacs-devel@gnu.org > Date: Mon, 26 Nov 2018 08:38:21 +0100 > > > It doesn't seem entirely trivial to me. ImageMagick caused quitea few > > problems to Emacs, so at this point I can only accept patches to > > support v7 on the release branch if the code used by v6.x is > > completely unchanged. > > Sorry, but where do you see a change that could affect behaviour of > v6.x? Effectively, the only code change in the consolidated patch is the > following in image.c: > > - MagickRealType color_scale = 65535.0 / QuantumRange; > + double quantum_range = QuantumRange; > + MagickRealType color_scale = 65535.0 / quantum_range; This is one part that I'd rather not do on the release branch (why is it needed, anyway?). The other one is that inclusion of a header file was moved to a different place for some reason. (Yes, I'm being paranoid ;-) > Also, I noticed that configure will silently disable imagemagick if v6 > is not found. This is o.k. for the default, but when I explicitly > specify --with-imagemagick, then I would expect it to error out when it > cannot enable the feature. Patches to that effect are welcome, but that part should definitely not go to the release branch. Thanks.