From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Fwd: Flymake and the 'face' property
Date: Wed, 30 Jan 2019 17:40:27 +0200 [thread overview]
Message-ID: <83zhri17dg.fsf@gnu.org> (raw)
In-Reply-To: <jwv7eemlcp5.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 30 Jan 2019 04:37:32 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 30 Jan 2019 04:37:32 -0500
>
> > A 'face' property is documented for general use only for text, not for
> > symbol plists.
>
> But the `category` text-property uses as text-properties the properties
> of a symbol, so there is a real conflict in our current design.
The 'category' symbols aren't faces, so there's no problem here. the
'face' property has special meaning only on symbols that name a face.
> I think it might be worth taking a look at how hard/easy it would be to
> change the place where we store the face-id.
I think you greatly exaggerate the importance of this incident. What
we have is a single package that happened to inadvertently bump into
this because it has a face and another symbol by the same name, _and_
that package also puts a 'face' property on the symbol. The solution,
which was already proposed, is to rename the face. Other than that,
this design is working flawlessly since the day it was introduced 19
years ago.
So I see no reason to waste any more energy on this. We have more
important issues to tend to.
next prev parent reply other threads:[~2019-01-30 15:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190128152540.6870.46132@vcs0.savannah.gnu.org>
[not found] ` <20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
2019-01-28 16:05 ` [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Daniel Colascione
2019-01-28 18:14 ` Eli Zaretskii
2019-01-28 19:37 ` Daniel Colascione
2019-01-28 20:19 ` Eli Zaretskii
2019-01-28 17:58 ` Glenn Morris
2019-01-28 20:05 ` Eli Zaretskii
2019-01-28 20:12 ` Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-28 20:39 ` João Távora
2019-01-28 20:57 ` Eli Zaretskii
2019-01-28 21:38 ` João Távora
2019-01-29 16:54 ` Eli Zaretskii
[not found] ` <CALDnm53FnkT+fjneg3uLNMsCu1MxJK1aKWQyvz85EjVdOyr4bg@mail.gmail.com>
2019-01-29 17:26 ` Fwd: " João Távora
2019-01-29 17:51 ` Eli Zaretskii
2019-01-29 17:54 ` Daniel Colascione
2019-01-29 18:30 ` Eli Zaretskii
2019-01-29 18:43 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:19 ` Eli Zaretskii
2019-01-29 18:47 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) João Távora
2019-01-29 18:53 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:00 ` João Távora
2019-01-29 19:21 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-29 19:28 ` João Távora
2019-01-29 18:28 ` João Távora
2019-01-29 18:34 ` Fwd: Flymake and the 'face' property Johan Bockgård
2019-01-29 18:49 ` João Távora
2019-01-29 19:17 ` Eli Zaretskii
2019-01-29 19:33 ` João Távora
2019-01-29 19:48 ` Eli Zaretskii
2019-01-29 19:58 ` João Távora
2019-01-30 9:37 ` Stefan Monnier
2019-01-30 15:40 ` Eli Zaretskii [this message]
2019-01-30 17:05 ` João Távora
2019-01-30 18:01 ` Eli Zaretskii
2019-01-30 20:56 ` Stefan Monnier
2019-01-31 3:38 ` Eli Zaretskii
2019-02-02 8:23 ` Stefan Monnier
2019-02-02 10:12 ` Eli Zaretskii
2019-02-02 22:49 ` Stefan Monnier
2019-02-03 3:39 ` Eli Zaretskii
2019-02-03 12:35 ` Stefan Monnier
2019-01-29 17:52 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhri17dg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).