From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 11:37:48 +0200
Message-ID: <83zhr6pqmr.fsf@gnu.org>
References: <20181214085417.15440.18845@vcs0.savannah.gnu.org>
	<20181214085418.6616820538@vcs0.savannah.gnu.org>
	<m2y38scndq.fsf@gmail.com> <831s6kgrtj.fsf@gnu.org>
	<m2pnu4cccx.fsf@gmail.com> <83pnu4f45d.fsf@gnu.org>
	<m2d0q0com0.fsf@gmail.com> <837eg8dpd6.fsf@gnu.org>
	<m2lg2qpv3h.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="210023"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 10:38:37 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gs2cF-000sTx-3f
	for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 10:38:35 +0100
Original-Received: from localhost ([127.0.0.1]:53759 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gs2cE-0001fT-4I
	for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 04:38:34 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:44745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gs2bZ-0001dL-Lc
	for emacs-devel@gnu.org; Fri, 08 Feb 2019 04:37:54 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41861)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gs2bX-00016f-Gz; Fri, 08 Feb 2019 04:37:52 -0500
Original-Received: from [176.228.60.248] (port=1731 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gs2bX-0006Nb-4Y; Fri, 08 Feb 2019 04:37:51 -0500
In-reply-to: <m2lg2qpv3h.fsf@gmail.com> (message from Robert Pluim on Fri, 08
	Feb 2019 09:01:22 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233113
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233113>

> From: Robert Pluim <rpluim@gmail.com>
> Cc: ari.roponen@gmail.com,  emacs-devel@gnu.org
> Date: Fri, 08 Feb 2019 09:01:22 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> >
> > Thanks, this LGTM, and is a significant improvement, IMO.  If no one
> > objects in a few days, please push.
> 
> I built this on GNU/Linux with the following configs:
> 
> ./configure                # This builds xfont.o ftfont.o xftfont.o ftxfont.o

I wonder why we build both xftfont.o and ftxfont.o, when we only use
one of them, if my reading of the code is correct.

> I can cherry-pick this to the harfbuzz branch if you want.

Thanks, please do.