From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c Date: Fri, 01 Mar 2019 18:22:39 +0200 Message-ID: <83zhqeh8ds.fsf@gnu.org> References: <20190222164522.GB5411@ACM> <20190225185656.GA3605@ACM> <20190301111018.GA5674@ACM> <83bm2uiu6x.fsf@gnu.org> <20190301141448.GC5674@ACM> <834l8mirj9.fsf@gnu.org> <20190301145856.GE5674@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="178160"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 01 17:32:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzl4r-000k9y-U3 for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 17:32:02 +0100 Original-Received: from localhost ([127.0.0.1]:40295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzl4q-0006VN-I2 for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 11:32:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzkw2-0008Iy-7k for emacs-devel@gnu.org; Fri, 01 Mar 2019 11:22:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzkw1-0007MH-OU; Fri, 01 Mar 2019 11:22:53 -0500 Original-Received: from [176.228.60.248] (port=4811 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzkw1-0000xY-9R; Fri, 01 Mar 2019 11:22:53 -0500 In-reply-to: <20190301145856.GE5674@ACM> (message from Alan Mackenzie on Fri, 1 Mar 2019 14:58:56 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233737 Archived-At: > Date: Fri, 1 Mar 2019 14:58:56 +0000 > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > From: Alan Mackenzie > > > > Thanks, I didn't know that. Maybe we should put an assert into the code, > > > like Stefan suggested. > > > We could try. > > How about this, as a first approximation? > [...] > + /* Check BYTEPOS was at a character boundary. */ > + eassert (best_below_byte == bytepos); Actually, what I had in mind was a simple eassert (CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos))); right at the beginning of buf_bytepos_to_charpos. But maybe if you explain why you wanted a different assertion, I will change my mind.