From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Emacs master build failing on RHEL 6.8
Date: Tue, 07 May 2019 18:52:13 +0300
Message-ID: <83zhnyi7o2.fsf@gnu.org>
References: <CAFyQvY36pa67zZgJqVYBM4xqLzWr7s_K1U7NfFeysKJTHN7E5Q@mail.gmail.com>
	<834l66jpty.fsf@gnu.org>
	<CAFyQvY2i5HFFdrAZ_3CV4u-oOxUXpOYF0AXG2wxW1VuP2P0ORg@mail.gmail.com>
	<831s1ajo0w.fsf@gnu.org> <jwvtve6e12c.fsf-monnier+emacs@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="264330"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 17:52:41 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hO2OW-0016cv-4J
	for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 17:52:40 +0200
Original-Received: from localhost ([127.0.0.1]:48989 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hO2OV-0006m4-47
	for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 11:52:39 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:39022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hO2OK-0006kV-MP
	for emacs-devel@gnu.org; Tue, 07 May 2019 11:52:29 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33499)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hO2OK-0003BW-CO; Tue, 07 May 2019 11:52:28 -0400
Original-Received: from [176.228.60.248] (port=1731 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hO2OJ-0007gh-Ic; Tue, 07 May 2019 11:52:28 -0400
In-reply-to: <jwvtve6e12c.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Tue, 07 May 2019 11:30:45 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236237
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236237>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Tue, 07 May 2019 11:30:45 -0400
> 
> Indeed, I'm surprised by:
> 
>   #if GNUC_PREREQ (4, 6, 0)
>    #pragma GCC diagnostic push
>   #endif
>   #if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0)
>    #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>   #endif
> 
> I always thought that the `#` at to be in column-0, hence the
> indentation convention of:
> 
>     #if foo
>     #  define BAR toto
>     #endif
> 
> But since this is coming from Paul, I assume he knows that it's allowed
> to have spaces before the `#` (at least in recent enough versions of C?).

Moreover, it works for everyone else, evidently, including with
GCC 7.x (which is what I have here).  Something strange goes on there.