From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Wed, 22 May 2019 12:50:26 +0300 Message-ID: <83zhne7r8d.fsf@gnu.org> References: <87pnobiglo.fsf@killashandra.ballybran.fr> <837eaj7x37.fsf@gnu.org> <3b0dc49f9831435178dc1b64d6a2f5c7@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149153"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Pierre =?utf-8?Q?T=C3=A9choueyres?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 22 12:11:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTODS-000cdv-RS for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 12:11:22 +0200 Original-Received: from localhost ([127.0.0.1]:39630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTODR-0004xu-SW for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 06:11:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTO7L-0008E8-QJ for emacs-devel@gnu.org; Wed, 22 May 2019 06:05:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTNt8-0007rc-0N; Wed, 22 May 2019 05:50:22 -0400 Original-Received: from [176.228.60.248] (port=3045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTNt5-0003ES-J0; Wed, 22 May 2019 05:50:20 -0400 In-reply-to: <3b0dc49f9831435178dc1b64d6a2f5c7@free.fr> (message from Pierre =?utf-8?Q?T=C3=A9choueyres?= on Wed, 22 May 2019 11:25:34 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236893 Archived-At: > Date: Wed, 22 May 2019 11:25:34 +0200 > From: Pierre Téchoueyres > Cc: emacs-devel@gnu.org > > Hello Eli, > > > > Thanks, but please avoid posting such large patches as long as you > > don't have a copyright assignment for Emacs on file. > > I have already signed paperwork for TRAMP and, I think, for Emacs. > But maybe there is something wrong with them ? I do see the assignment for Tramp, but not for Emacs. > If you can't find my previous assignment, then yes send me them back. Will send off-list. > I would like to have some discussion on how to improve some points : > - Is adding parameter to existing functions the way to go or is it > better to add new ones for base64url I think an optional argument will be fine. > - I would like to improve base64-decode* in a way it could detect the > variant but actually don't know how to do that. Maybe someone else will have an idea. Is such an algorithmic detection described someplace? > - The documentations is not really what I would like to see (and there > my English is faulty) Don't worry about that, we will polish it when the time comes. Thanks for providing the documentation in the first place.