From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: High-res Customize icons Date: Fri, 01 May 2020 16:46:43 +0300 Message-ID: <83zharvkcc.fsf@gnu.org> References: <6AEA7E43-DB35-458F-AFF2-B45DCBDC136F@gmail.com> <83a734fecm.fsf@gnu.org> <9713d235-11d4-b593-210a-e389c265e8ad@gmail.com> <83368vfxtl.fsf@gnu.org> <83imhre827.fsf@gnu.org> <83a733e56k.fsf@gnu.org> <834ktbe2ve.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yandros@gmail.com, cpitclaudel@gmail.com, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 15:47:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUW0x-000VvB-JY for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 15:47:39 +0200 Original-Received: from localhost ([::1]:58374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUW0w-0001a2-KN for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 09:47:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58010) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUW0G-0000TD-M6 for emacs-devel@gnu.org; Fri, 01 May 2020 09:46:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55224) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUW0G-0005do-2E; Fri, 01 May 2020 09:46:56 -0400 Original-Received: from [176.228.60.248] (port=2356 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUW0F-00067k-Ga; Fri, 01 May 2020 09:46:55 -0400 In-Reply-To: (message from Yuan Fu on Wed, 22 Apr 2020 16:38:10 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248301 Archived-At: > From: Yuan Fu > Date: Wed, 22 Apr 2020 16:38:10 -0400 > Cc: yandros@gmail.com, > cpitclaudel@gmail.com, > emacs-devel@gnu.org > > Here is a patch for the high-res icons. Put both icon files under /etc/images/custom. > > In the patch I modified widget-image-find to look for @2x images. Can we even modify find-image so it looks for @2x images (as an opt-in feature)? That way Other applications (Magit, gdb-mi, etc) that uses images icons in buffer and fringe could have high-res icons without changing a line of code (assuming they use find-image). I think Emacs should look in the hi-res subdirectory when the display is high resolution. A defcustom sounds like a wrong way to handle this issue.