From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Changes for emacs 28
Date: Fri, 11 Sep 2020 09:39:30 +0300
Message-ID: <83zh5whl5p.fsf@gnu.org>
References: <20200910231420.kvqg6ohvxetpup5c.ref@Ergus>
 <20200910231420.kvqg6ohvxetpup5c@Ergus>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="13336"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: rekado@elephly.net, ghe@sdf.org, drew.adams@oracle.com, emacs-devel@gnu.org
To: Ergus <spacibba@aol.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 11 08:40:03 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kGcj5-0003MB-3V
	for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 08:40:03 +0200
Original-Received: from localhost ([::1]:39368 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kGcj4-00075m-2e
	for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 02:40:02 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36598)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kGciW-0006gc-GT
 for emacs-devel@gnu.org; Fri, 11 Sep 2020 02:39:28 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47910)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kGciV-0003gf-2k; Fri, 11 Sep 2020 02:39:27 -0400
Original-Received: from [176.228.60.248] (port=3557 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kGciT-0005hJ-1p; Fri, 11 Sep 2020 02:39:26 -0400
In-Reply-To: <20200910231420.kvqg6ohvxetpup5c@Ergus> (message from Ergus on
 Fri, 11 Sep 2020 01:14:20 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:255100
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/255100>

> Date: Fri, 11 Sep 2020 01:14:20 +0200
> From: Ergus <spacibba@aol.com>
> Cc: Ricardo Wurmus <rekado@elephly.net>, Gregory Heytings <ghe@sdf.org>,
>  emacs-devel@gnu.org
> 
> 3) Is it possible/should we: add a redo icon in the toolbar
> conditionally when the mode is enabled?
> 
> else
> 
> 4) I see a redo added in the menu-bar unconditionally... should we do
> the same in the toolbar unconditionally?

I indeed think that the Redo icon should be added unconditionally
(enabled only when there's something to redo, like the menu item).