From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sun, 13 Sep 2020 17:37:02 +0300 Message-ID: <83zh5tbv5d.fsf@gnu.org> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> <837dszdyqv.fsf@gnu.org> <877dsz2o03.fsf@gnus.org> <874ko3gcwa.fsf@gmx.de> <87v9ghzwj2.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, emacs-devel@gnu.org, michael.albinus@gmx.de, mardani29@yahoo.es To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 16:37:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHT8L-0007pC-CA for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 16:37:37 +0200 Original-Received: from localhost ([::1]:60630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHT8K-0001R3-Do for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 10:37:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHT7l-0000bt-Ui for emacs-devel@gnu.org; Sun, 13 Sep 2020 10:37:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58826) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHT7l-0006dO-CD; Sun, 13 Sep 2020 10:37:01 -0400 Original-Received: from [176.228.60.248] (port=4215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHT7k-00039i-OQ; Sun, 13 Sep 2020 10:37:01 -0400 In-Reply-To: <87v9ghzwj2.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Sep 2020 14:33:21 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255493 Archived-At: > From: Lars Ingebrigtsen > Date: Sun, 13 Sep 2020 14:33:21 +0200 > Cc: Eli Zaretskii , mardani29@yahoo.es, stefan@marxist.se, > emacs-devel@gnu.org > > Michael Albinus writes: > > > When I have marked tests as expensive, I've always checked that the test > > isn't needed for the basic feature, and whether the test runs long. I > > believe an expensive test must be evaluated for both criteria. > > Hm... I guess that sounds reasonable, but I don't agree. :-) The only > feature that is so basic that it has to run, no matter how long it > takes, is "does Emacs start?", and that test is a lot faster than a > second. I think that's a slippery slope. We will very quickly end up with many bugs that aren't uncovered in time.