From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: mouse-face and help echo support for xterm mouse Date: Fri, 06 Nov 2020 09:39:37 +0200 Message-ID: <83zh3v7x3a.fsf@gnu.org> References: <946d9ea094642758037d1881a97e8d0c@finder.org> <6e5a5cde54359702c36d1371861f30c3@finder.org> <831rh79g97.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 08:41:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kawMy-0009mM-O4 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 08:41:12 +0100 Original-Received: from localhost ([::1]:57302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kawMx-0005Nr-Lz for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 02:41:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kawLW-0004nL-Mh for emacs-devel@gnu.org; Fri, 06 Nov 2020 02:39:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48464) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kawLV-0005Lw-Kk; Fri, 06 Nov 2020 02:39:41 -0500 Original-Received: from [176.228.60.248] (port=1052 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kawLV-0007kM-0C; Fri, 06 Nov 2020 02:39:41 -0500 In-Reply-To: (message from Jared Finder on Thu, 05 Nov 2020 22:46:32 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258778 Archived-At: > Date: Thu, 05 Nov 2020 22:46:32 -0800 > From: Jared Finder > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > > >> (defface mode-line-highlight > >> - '((((class color) (min-colors 88)) > >> + '((((type graphic) (class color) (min-colors 88)) > >> :box (:line-width 2 :color "grey40" :style released-button)) > > > > I don't think I understand the rationale. With TTYs supporting many > > colors nowadays, and mode-line-highlight available on TTYs, what is > > the problem you tried to fix here? > > Are there any TTYs that support :box? None of the platforms I tested > locally on do, they instead just ignore the :box aspect of any face. That's true, but having conditions where they aren't necessary is not good for maintenance, because they aren't future-proof: they will need changes should someone implement the :box attribute for TTYs. We've bumped into such problems many times during the last two decades: as more and more display features (colors, menus, mouse) became supported on TTYs, we time after time found them not working in some package, because someone arbitrarily disabled that for TTYs on the assumption that "TTYs cannot possibly do that". So attributes that are silently and harmlessly ignored should not in general be disabled. If you want, we can add a more reasonable condition, using the 'supports' keyword, requesting specifically support for the :box attribute. Thanks.