From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com, phst@google.com
Cc: emacs-devel@gnu.org
Subject: Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.
Date: Mon, 09 Nov 2020 21:46:32 +0200 [thread overview]
Message-ID: <83zh3q2u07.fsf@gnu.org> (raw)
In-Reply-To: <831rh248xu.fsf@gnu.org> (message from Eli Zaretskii on Mon, 09 Nov 2020 21:38:37 +0200)
> Date: Mon, 09 Nov 2020 21:38:37 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: phst@google.com, emacs-devel@gnu.org
>
> > - ;; Due to limitations on Emacs integer values, faces with
> > - ;; face id greater than 512 are silently ignored.
> > (if (not face)
> > char
> > (let ((fid (face-id face)))
>
> Is this comment really obsolete? We still need to be able to pack a
> face ID and a 22-bit character codepoint into a single fixnum, which
> could be a 32-bit data type. See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
> and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.
Sorry, ignore me.
next prev parent reply other threads:[~2020-11-09 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201109171613.6680.13417@vcs0.savannah.gnu.org>
[not found] ` <20201109171614.766A220A27@vcs0.savannah.gnu.org>
2020-11-09 19:38 ` master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment Eli Zaretskii
2020-11-09 19:46 ` Eli Zaretskii [this message]
2020-11-09 19:46 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zh3q2u07.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).