From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v2 10/16] Add and use KILL_PER_BUFFER_VALUE
Date: Tue, 01 Dec 2020 19:26:45 +0200
Message-ID: <83zh2xh1yi.fsf@gnu.org>
References: <20201119153814.17541-1-sbaugh@catern.com>
 <cover.1606009917.git.sbaugh@catern.com>
 <2199f68b31e8be553780fed0e78457831b47f29e.1606009917.git.sbaugh@catern.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="26531"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, arnold@tdrhq.com, dgutov@yandex.ru,
 monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Spencer Baugh <sbaugh@catern.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 01 18:38:31 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk9bh-0006hX-7x
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 18:38:29 +0100
Original-Received: from localhost ([::1]:60324 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk9bg-0008Ft-7D
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 12:38:28 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37920)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kk9Qe-0006T2-DR
 for emacs-devel@gnu.org; Tue, 01 Dec 2020 12:27:05 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59256)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kk9Qd-0003Hd-Op; Tue, 01 Dec 2020 12:27:03 -0500
Original-Received: from [176.228.60.248] (port=4163 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kk9QQ-0005E6-LU; Tue, 01 Dec 2020 12:26:54 -0500
In-Reply-To: <2199f68b31e8be553780fed0e78457831b47f29e.1606009917.git.sbaugh@catern.com>
 (message from Spencer Baugh on Sat, 21 Nov 2020 21:34:39 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:260144
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/260144>

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:39 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> This improves clarity and removes usage of idx.

Same comment as earlier regarding changes related to idx.

As for clarity: you introduced an inline function, which will make the
code slower in unoptimized builds.  If you think the benefits from
bringing these two operations together will benefit readability, let's
make that a macro, not a function.

Thanks.