From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Lift {global,local}-key-binding to Lisp Date: Wed, 13 Jan 2021 21:26:37 +0200 Message-ID: <83zh1cbpua.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20352"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 13 20:28:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzlol-0005BT-Mi for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Jan 2021 20:28:31 +0100 Original-Received: from localhost ([::1]:39822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzlok-0001Ef-OX for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Jan 2021 14:28:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzln0-0000Mj-KE for emacs-devel@gnu.org; Wed, 13 Jan 2021 14:26:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34366) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzlmz-0005EJ-T8; Wed, 13 Jan 2021 14:26:41 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4165 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kzlmx-0006fm-Cn; Wed, 13 Jan 2021 14:26:41 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263039 Archived-At: commit a9658cd5b07e88a5d413cbb4dfd8f9d9d0c8bbf5 Author: Stefan Kangas AuthorDate: Wed Jan 13 18:54:09 2021 +0100 Commit: Stefan Kangas CommitDate: Wed Jan 13 18:54:09 2021 +0100 Lift {global,local}-key-binding to Lisp * lisp/subr.el (local-key-binding, global-key-binding): New defuns. * src/keymap.c (Flocal_key_binding, Fglobal_key_binding): Remove DEFUNs. (syms_of_keymap): Remove defsubrs for above DEFUNs. * test/lisp/subr-tests.el (subr-test-local-key-binding) (subr-test-global-key-binding): New tests. Stefan, why are we moving these and other functions to Lisp? Are there any advantages to moving them? Is there any plan behind this and other similar changes? And why don't we discuss such changes before making them? In general, unless we get some significant gains, I'd prefer not to move around code just to move it. If nothing else, it makes it harder for people who, like me, are familiar with the original code, to find stuff, because suddenly it isn't where it used to be. The result is that I cannot use my memory anymore, I need to consult the code each time I need to answer some question or consider something related to this code. It's a needless churn, and I ask myself what do we gain in return?