From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Thu, 25 Feb 2021 21:11:16 +0200 Message-ID: <83zgzsq7xn.fsf@gnu.org> References: <87h7m5iagw.fsf@gnus.org> <83blc9tnvz.fsf@gnu.org> <83y2fcrzkt.fsf@gnu.org> <831rd4romg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16374"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 25 20:15:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFM6o-00048F-0U for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 20:15:34 +0100 Original-Received: from localhost ([::1]:56626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFM6n-0000zT-1x for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 14:15:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFM3A-00081Q-Sh for emacs-devel@gnu.org; Thu, 25 Feb 2021 14:11:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33774) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFM2w-0006ay-U5; Thu, 25 Feb 2021 14:11:41 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2109 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lFM2t-0003oV-BP; Thu, 25 Feb 2021 14:11:32 -0500 In-Reply-To: (message from Stefan Kangas on Thu, 25 Feb 2021 12:48:37 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265641 Archived-At: > From: Stefan Kangas > Date: Thu, 25 Feb 2021 12:48:37 -0600 > Cc: larsi@gnus.org, emacs-devel@gnu.org > > >> 2. M-: (insert (propertize "foo" 'help-echo "foo \\[forward-line]")) RET > >> > >> No visible effect on the tooltip --with-x-toolkit={gtk,lucid,athena,no}. > > > > And the face for keys is defined how? > > (defface help-key-binding '((t :foreground "RoyalBlue3")) > "Face for keybindings in *Help* buffers." > :version "28.1" > :group 'help) Ah, okay: you are putting the 'face' property, but so does 'tooltip-show'. So yes, the latter one overrides the former one. So I guess we will need to change the design of this to avoid overriding the whole face of a tooltip, or maybe add some special code to help_echo_substitute_command_keys.