unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 050b830 3/3: Do interactive mode tagging for finder.el
Date: Fri, 19 Mar 2021 10:15:17 +0200	[thread overview]
Message-ID: <83zgyzeezu.fsf@gnu.org> (raw)

> @@ -423,7 +423,7 @@ FILE should be in a form suitable for passing to `locate-library'."
>  
>  (defun finder-mouse-select (event)
>    "Select item in a Finder buffer with the mouse."
> -  (interactive "e")
> +  (interactive "e" finder-mode)
>    (with-current-buffer (window-buffer (posn-window (event-start event)))
>      (goto-char (posn-point (event-start event)))
>      (finder-select)))

I think this part is dangerous: mouse commands are not necessarily
issued with the buffer on which they operate being current, so
conditioning such commands on the mode of the current buffer is
ill-advised.  Even if currently this marking doesn't produce any
visible problems (does it?), it could do so in the future, if and when
we decide to base more on this tagging than we do now.

I think this part should be reverted, and in the future commands bound
to mouse clicks should not be tagged with any major mode.

Thanks.



             reply	other threads:[~2021-03-19  8:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  8:15 Eli Zaretskii [this message]
2021-03-19  8:28 ` master 050b830 3/3: Do interactive mode tagging for finder.el Lars Ingebrigtsen
2021-03-19  8:37   ` Eli Zaretskii
2021-03-19 16:23     ` Stefan Kangas
2021-03-19 16:35       ` Eli Zaretskii
2021-03-19 17:08         ` Stefan Kangas
2021-03-19 19:39           ` Eli Zaretskii
2021-03-19 19:55             ` [External] : " Drew Adams
2021-03-20  7:51         ` Lars Ingebrigtsen
2021-03-20  8:15           ` Lars Ingebrigtsen
2021-03-20  9:02           ` Eli Zaretskii
2021-03-20  9:05             ` Lars Ingebrigtsen
2021-03-20  9:23               ` Eli Zaretskii
2021-03-21  7:47                 ` Lars Ingebrigtsen
2021-03-19 17:22       ` Dmitry Gutov
2021-03-19 17:47         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgyzeezu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).