unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition.
Date: Thu, 15 Jul 2021 17:16:37 +0300	[thread overview]
Message-ID: <83zgun64sa.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmt24kKukWHxC86+cffsjKpHHAzxJ+omO32WDuzBdpbxw@mail.gmail.com> (message from Stefan Kangas on Thu, 15 Jul 2021 13:53:20 +0200)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 15 Jul 2021 13:53:20 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >  *** New function 'split-string-shell-command'.
> > -This splits a shell string into separate components, respecting single
> > -and double quotes, as well as backslash quoting.
> > +This splits a shell command string into separate components,
> > +respecting quoting with single ('like this') and double ("like this")
> > +quotes, as well as backslash quoting (like\ this).
> 
> Arguably nit-picking, but would it better to say "a string containing
> a shell command"?  It could be unclear here what a "shell command
> string" is; a reader might believe it's a special string type.

"A string containing SOMETHING" sounds strange to me.  In particular,
it could be interpreted to mean the string contains something else, in
addition to the shell command.  "Shell command string" is a string
that is a shell command.



  reply	other threads:[~2021-07-15 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210715092410.26215.24260@vcs0.savannah.gnu.org>
     [not found] ` <20210715092412.6EC9720D13@vcs0.savannah.gnu.org>
2021-07-15 11:53   ` master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition Stefan Kangas
2021-07-15 14:16     ` Eli Zaretskii [this message]
2021-07-15 14:38       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgun64sa.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).