From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Fri, 30 Jul 2021 09:00:39 +0300 Message-ID: <83zgu4qr20.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> <835ywutmpu.fsf@gnu.org> <867dh8pw0w.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13659"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 30 08:02:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9Laq-0003Q4-Qh for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Jul 2021 08:02:00 +0200 Original-Received: from localhost ([::1]:34210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9Lap-0001xG-A8 for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Jul 2021 02:01:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9LZr-0001F0-UV for emacs-devel@gnu.org; Fri, 30 Jul 2021 02:00:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33224) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9LZr-0003cM-Fz; Fri, 30 Jul 2021 02:00:59 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2960 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9LZo-0004fr-7p; Fri, 30 Jul 2021 02:00:56 -0400 In-Reply-To: <867dh8pw0w.fsf@stephe-leake.org> (message from Stephen Leake on Thu, 29 Jul 2021 15:58:39 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271824 Archived-At: > From: Stephen Leake > Cc: Yuan Fu , emacs-devel@gnu.org, > cpitclaudel@gmail.com, monnier@iro.umontreal.ca > Date: Thu, 29 Jul 2021 15:58:39 -0700 > > Eli Zaretskii writes: > > >> From: Yuan Fu > >> Date: Wed, 28 Jul 2021 12:36:33 -0400 > >> Cc: Eli Zaretskii , > >> emacs-devel , > >> Clément Pit-Claudel , > >> monnier@iro.umontreal.ca > >> > >> > So don't send a change that deletes the hidden text; just send changes > >> > in the visible part of the text (that's the only place the user can make > >> > changes). tree-sitter will only run the scanner on the change regions, > >> > so it will only request text from the visible part of the buffer; > >> > all the requests will succeed. > >> > >> Then we are not hiding the hidden text from tree-sitter. The > >> implementation you described, IIUC, is essentially do nothing > >> special when the buffer is narrowed. > > > > If the TS parser is called while the narrowing is in effect, it will > > be unable to access text beyond BEGV..ZV. So in that case the > > narrowing _will_ affect TS. > > Please read again; TS is affected in principle, but in practice, in the > absence of programming errors, it will never try to access text outside > the narrowing, so it won't notice. Sorry, I don't understand what you wanted me to re-read. As the subsequent discussions revealed, Yuan had in mind a scenario where the text outside of the restriction was changed.