From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fixing post-self-insert-hook. Date: Sat, 18 Sep 2021 14:04:44 +0300 Message-ID: <83zgsa5elv.fsf@gnu.org> References: <83ilyy77q5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10030"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 18 13:06:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRYAd-0002TI-BB for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Sep 2021 13:06:11 +0200 Original-Received: from localhost ([::1]:51862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRYAc-0006jD-0l for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Sep 2021 07:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRY9S-0005y5-Cq for emacs-devel@gnu.org; Sat, 18 Sep 2021 07:04:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49508) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRY9R-0007bw-LD; Sat, 18 Sep 2021 07:04:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2583 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRY9Q-0000FS-I8; Sat, 18 Sep 2021 07:04:57 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 18 Sep 2021 09:57:19 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274983 Archived-At: > Date: Sat, 18 Sep 2021 09:57:19 +0000 > Cc: emacs-devel@gnu.org, joaotavora@gmail.com > From: Alan Mackenzie > > > If CC Mode has problem with these hooks, it could bind them to nil > > around the call to self-insert-command, couldn't it? > > That has indeed been done since early 2019. It's not nice. It involves > c-electric-brace knowing that one of the entries in post-self-insert-hook > is electric-pair-post-self-insert-function, and calling it explicitly. > It couples the electric-... minor modes with CC Mode, and blocks out any > other functionality on the hook from CC Mode. > > > That'd be much better than making any globally-visible change in > > behavior, for which we cannot possibly know the unintended > > consequences. > > The mechanism is currently broken. Do we stick with this known breakage > for fear of an unknown, not particularly likely one, or do we fix it? The former, I hope. > > In any case, please let's not make this change before the emacs-28 > > branch is cut, as it can potentially disrupt many places. > > Yes. But surely we have enough time before Emacs 29 for any problems it > might cause to come to light. I don't know. We don't even have any clear idea of what problems it causes in practice, only some vague fears of such problems.