From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve interaction between mouse-drag-region and scroll-margin Date: Sat, 25 Sep 2021 19:17:21 +0300 Message-ID: <83zgs0pr3i.fsf@gnu.org> References: <20210925160922.114811-1-wavexx@thregr.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wavexx@thregr.org, emacs-devel@gnu.org To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 25 18:18:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUANY-0007U5-Fz for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Sep 2021 18:18:20 +0200 Original-Received: from localhost ([::1]:43782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUANW-0005Ro-GQ for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Sep 2021 12:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUAMg-0004Uk-VM for emacs-devel@gnu.org; Sat, 25 Sep 2021 12:17:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47464) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUAMf-0000bT-Lh; Sat, 25 Sep 2021 12:17:25 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUAMf-0003qi-3k; Sat, 25 Sep 2021 12:17:25 -0400 In-Reply-To: <20210925160922.114811-1-wavexx@thregr.org> (message from Yuri D'Elia on Sat, 25 Sep 2021 18:09:22 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275459 Archived-At: > From: Yuri D'Elia > Date: Sat, 25 Sep 2021 18:09:22 +0200 > Cc: Yuri D'Elia > > * lisp/mouse.el (mouse-drag-track): Disable both scroll-margin and > auto-hscroll-mode in mouse-drag-region and do not re-enable them until > dragging is over, making selections work as expected when inside the > margins. If you disable auto-hscroll-mode, why do you also need to zero out hscroll-margin? > + ;; Suppress automatic scrolling near the edges while tracking > + ;; movement, as it interferes with the natural dragging behavior > + ;; (point will unexpectedly be moved beneath the pointer, making > + ;; selections in auto-scrolling margins impossible). > + (setq auto-hscroll-mode nil) > + (setq scroll-margin 0) Shouldn't this be in unwind-protect? What happens if Emacs signals an error or there's a quit while in this code? And I think this also warrants a NEWS entry. Thanks.